| Message ID | 20240811164455.5984-1-stephen@networkplumber.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6d632bbcda73d9c08534cad279a11d9a985deacc |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute] man/ip-xfrm: fix dangling quote | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Sun, Aug 11, 2024 at 09:44:46AM -0700, Stephen Hemminger wrote: > The man page had a dangling quote character in the usage. I run "man -l man/man8/ip-xfrm.8" before and after that patch and I don't see any difference. Can you please provide more details? Thanks > > Fixes: bdd19b1edec4 ("xfrm: prepare state offload logic to set mode") > Cc: leonro@nvidia.com > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > man/man8/ip-xfrm.8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/man8/ip-xfrm.8 b/man/man8/ip-xfrm.8 > index 960779dd..3efd6172 100644 > --- a/man/man8/ip-xfrm.8 > +++ b/man/man8/ip-xfrm.8 > @@ -71,7 +71,7 @@ ip-xfrm \- transform configuration > .RB "[ " offload > .RB "[ " crypto | packet " ]" > .RB dev > -.IR DEV " > +.I DEV > .RB dir > .IR DIR " ]" > .RB "[ " tfcpad > -- > 2.43.0 > >
On Mon, 12 Aug 2024 10:33:20 +0300 Leon Romanovsky <leon@kernel.org> wrote: > On Sun, Aug 11, 2024 at 09:44:46AM -0700, Stephen Hemminger wrote: > > The man page had a dangling quote character in the usage. > > I run "man -l man/man8/ip-xfrm.8" before and after that patch and I > don't see any difference. Can you please provide more details? > > Thanks It is more because Emacs auto-colorizing of man page gets confused by the single quote character.
On Mon, Aug 12, 2024, at 17:59, Stephen Hemminger wrote: > On Mon, 12 Aug 2024 10:33:20 +0300 > Leon Romanovsky <leon@kernel.org> wrote: > >> On Sun, Aug 11, 2024 at 09:44:46AM -0700, Stephen Hemminger wrote: >> > The man page had a dangling quote character in the usage. >> >> I run "man -l man/man8/ip-xfrm.8" before and after that patch and I >> don't see any difference. Can you please provide more details? >> >> Thanks > > It is more because Emacs auto-colorizing of man page > gets confused by the single quote character. Ok, thanks
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Sun, 11 Aug 2024 09:44:46 -0700 you wrote: > The man page had a dangling quote character in the usage. > > Fixes: bdd19b1edec4 ("xfrm: prepare state offload logic to set mode") > Cc: leonro@nvidia.com > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > man/man8/ip-xfrm.8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [iproute] man/ip-xfrm: fix dangling quote https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=6d632bbcda73 You are awesome, thank you!
diff --git a/man/man8/ip-xfrm.8 b/man/man8/ip-xfrm.8 index 960779dd..3efd6172 100644 --- a/man/man8/ip-xfrm.8 +++ b/man/man8/ip-xfrm.8 @@ -71,7 +71,7 @@ ip-xfrm \- transform configuration .RB "[ " offload .RB "[ " crypto | packet " ]" .RB dev -.IR DEV " +.I DEV .RB dir .IR DIR " ]" .RB "[ " tfcpad
The man page had a dangling quote character in the usage. Fixes: bdd19b1edec4 ("xfrm: prepare state offload logic to set mode") Cc: leonro@nvidia.com Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- man/man8/ip-xfrm.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)