diff mbox series

[ethtool] netlink: settings: Fix lanes parameter format specifier

Message ID 20240812141111.3718889-1-danieller@nvidia.com (mailing list archive)
State Accepted
Delegated to: Michal Kubecek
Headers show
Series [ethtool] netlink: settings: Fix lanes parameter format specifier | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Danielle Ratson Aug. 12, 2024, 2:11 p.m. UTC 
Lanes parameter is not printed well on ethtool base command causing the
following output:

$ ethtool swp1

[..]
        Speed: 400000Mb/s
Segmentation fault (core dumped)

Use the "%u" format specifier instead of "%s", since the lanes parameter
type is unsigned integer and not a string.

Fixes: bd1341cd2146 ("add json support for base command")
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/netlink/settings.c b/netlink/settings.c
index 9dd688b..62dd339 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -527,7 +527,7 @@  int linkmodes_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		uint32_t val = mnl_attr_get_u32(tb[ETHTOOL_A_LINKMODES_LANES]);
 
 		print_banner(nlctx);
-		print_uint(PRINT_ANY, "lanes", "\tLanes: %s\n", val);
+		print_uint(PRINT_ANY, "lanes", "\tLanes: %u\n", val);
 	}
 	if (tb[ETHTOOL_A_LINKMODES_DUPLEX]) {
 		uint8_t val = mnl_attr_get_u8(tb[ETHTOOL_A_LINKMODES_DUPLEX]);