From patchwork Mon Aug 19 07:12:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jijie Shao X-Patchwork-Id: 13767994 X-Patchwork-Delegate: kuba@kernel.org Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A122C1598F4; Mon, 19 Aug 2024 07:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724051990; cv=none; b=fB8bk/u9lctmOOFuCdkgDTQCSXeQ9q3Tau3BAm8TmuDA/a6mhDNzqtaj2NtIOnXmptZBc0XAZ+AYzO+i2fdEC2073zNiUu7mgCut9LGHbk+RzdpEbxlO4nPttyhG/Lv8kj0RU10aBBSSVln2dNbjtE2OlkrFLK7gCaPn61Rk7Lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724051990; c=relaxed/simple; bh=BVoF6xKSHJyIe3qsWJNAKz/mPt6vgQCUQQFOTncLDlQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UhlosL3jvR1wmg02BsvteZxxMu8zV24ZTuHhKzCngtPVfvZ7xErNA6xZbFBgKuwxEQuxrB4qGHLxdiDVD/A4ntRauO6QY/3hptFUD1vk5sfVmGd1RgV+Dix8ntPPXdPoExAkWiQlaZ4F24vkxljlwz3XpKVMkYFEBgK5ANZ/X44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WnP6D3CPPz1HGnP; Mon, 19 Aug 2024 15:16:36 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id 27D441A0188; Mon, 19 Aug 2024 15:19:46 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 15:19:45 +0800 From: Jijie Shao To: , , , , , , CC: , , , , , , , , , , , , , Subject: [PATCH net-next 11/11] net: add is_valid_ether_addr check in dev_set_mac_address Date: Mon, 19 Aug 2024 15:12:29 +0800 Message-ID: <20240819071229.2489506-12-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240819071229.2489506-1-shaojijie@huawei.com> References: <20240819071229.2489506-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000007.china.huawei.com (7.193.23.189) X-Patchwork-Delegate: kuba@kernel.org core need test the mac_addr not every driver need to do. Signed-off-by: Jijie Shao --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 751d9b70e6ad..ad86b8c939c1 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9087,6 +9087,8 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa, return -EOPNOTSUPP; if (sa->sa_family != dev->type) return -EINVAL; + if (!is_valid_ether_addr(sa->sa_data)) + return -EADDRNOTAVAIL; if (!netif_device_present(dev)) return -ENODEV; err = dev_pre_changeaddr_notify(dev, sa->sa_data, extack);