From patchwork Tue Aug 20 14:01:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jijie Shao X-Patchwork-Id: 13770177 X-Patchwork-Delegate: kuba@kernel.org Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D9419306F; Tue, 20 Aug 2024 14:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162919; cv=none; b=ISHuOf7alTxbHdkv10uwp0Z3k+scIJKhcn1rF0wwVHONaka/pd4rRYQDTSSpOYIJsrJomodpITDalnOehZ/XjlANzlxfFCJJZpBM0Ov/K704b8H7mwgrBWzdOiI7C+gisYYtlclPcA3D3FrBFpQS4Wyf5a7VOllXXysJm1kN95w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162919; c=relaxed/simple; bh=WzyxIN+qZsUDOzxz7qIipBoNl947Wm05mfAz5ecn+8U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TL0a9NuIfGBToh1ZyqB6fkBlUWdFXQcZX121X7nADw59xXYLOE7cANizPce93HsLRY/7BOdC4es6zwP3cDkgoC/sSwgpCyCcozG+NYSFVWqfggZglw/WxyfcJI5MFr7peCp2AVNQKPPuEIFS6WgJpoNVS/u6SeXJHJHPcbgpGGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WpB5l0xmhz20mCL; Tue, 20 Aug 2024 22:03:55 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id CDEB91A0188; Tue, 20 Aug 2024 22:08:35 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 20 Aug 2024 22:08:34 +0800 From: Jijie Shao To: , , , CC: , , , , , , , , , , , , , , , Subject: [PATCH V2 net-next 11/11] net: add is_valid_ether_addr check in dev_set_mac_address Date: Tue, 20 Aug 2024 22:01:54 +0800 Message-ID: <20240820140154.137876-12-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240820140154.137876-1-shaojijie@huawei.com> References: <20240820140154.137876-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000007.china.huawei.com (7.193.23.189) X-Patchwork-Delegate: kuba@kernel.org core need test the mac_addr not every driver need to do. Signed-off-by: Jijie Shao --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index e7260889d4cb..2e19712184bc 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9087,6 +9087,8 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa, return -EOPNOTSUPP; if (sa->sa_family != dev->type) return -EINVAL; + if (!is_valid_ether_addr(sa->sa_data)) + return -EADDRNOTAVAIL; if (!netif_device_present(dev)) return -ENODEV; err = dev_pre_changeaddr_notify(dev, sa->sa_data, extack);