| Message ID | 20240822213410.644665-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] idpf: make read-only arrays tx_itr and rx_itr static const | expand |
From: Colin Ian King <colin.i.king@gmail.com> Date: Thu, 22 Aug 2024 22:34:10 +0100 > Don't populate the read-only arrays tx_itr and rx_itr on the stack at > run time, instead make them static const. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > index 70986e12da28..d50e5cab05fc 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > @@ -3149,8 +3149,8 @@ void idpf_vport_init(struct idpf_vport *vport, struct idpf_vport_max_q *max_q) > struct idpf_adapter *adapter = vport->adapter; > struct virtchnl2_create_vport *vport_msg; > struct idpf_vport_config *vport_config; > - u16 tx_itr[] = {2, 8, 64, 128, 256}; > - u16 rx_itr[] = {2, 8, 32, 96, 128}; > + static const u16 tx_itr[] = {2, 8, 64, 128, 256}; > + static const u16 rx_itr[] = {2, 8, 32, 96, 128}; Move it to the top of the function to keep the RCT style? > struct idpf_rss_data *rss_data; > u16 idx = vport->idx; Thanks, Olek
diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index 70986e12da28..d50e5cab05fc 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -3149,8 +3149,8 @@ void idpf_vport_init(struct idpf_vport *vport, struct idpf_vport_max_q *max_q) struct idpf_adapter *adapter = vport->adapter; struct virtchnl2_create_vport *vport_msg; struct idpf_vport_config *vport_config; - u16 tx_itr[] = {2, 8, 64, 128, 256}; - u16 rx_itr[] = {2, 8, 32, 96, 128}; + static const u16 tx_itr[] = {2, 8, 64, 128, 256}; + static const u16 rx_itr[] = {2, 8, 32, 96, 128}; struct idpf_rss_data *rss_data; u16 idx = vport->idx;
Don't populate the read-only arrays tx_itr and rx_itr on the stack at run time, instead make them static const. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)