| Message ID | 20240902111052.2686366-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] netlink: Use the BITS_PER_LONG macro | expand |
On Mon, 2 Sep 2024 19:10:52 +0800 Jinjie Ruan wrote: > sizeof(unsigned long) * 8 is the number of bits in an unsigned long > variable, replace it with BITS_PER_LONG macro to make it simpler. Does coccicheck catch such cases?
On 2024/9/3 9:39, Jakub Kicinski wrote: > On Mon, 2 Sep 2024 19:10:52 +0800 Jinjie Ruan wrote: >> sizeof(unsigned long) * 8 is the number of bits in an unsigned long >> variable, replace it with BITS_PER_LONG macro to make it simpler. > > Does coccicheck catch such cases? Yes
On Tue, 3 Sep 2024 10:06:02 +0800 Jinjie Ruan wrote: > > Does coccicheck catch such cases? > > Yes which script?
diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h index 5b0e4e62ab8b..e369980e30e3 100644 --- a/net/netlink/af_netlink.h +++ b/net/netlink/af_netlink.h @@ -19,7 +19,7 @@ enum { NETLINK_F_STRICT_CHK, }; -#define NLGRPSZ(x) (ALIGN(x, sizeof(unsigned long) * 8) / 8) +#define NLGRPSZ(x) (ALIGN(x, BITS_PER_LONG) / 8) #define NLGRPLONGS(x) (NLGRPSZ(x)/sizeof(unsigned long)) struct netlink_sock {
sizeof(unsigned long) * 8 is the number of bits in an unsigned long variable, replace it with BITS_PER_LONG macro to make it simpler. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- net/netlink/af_netlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)