diff mbox series

[net-next,01/16] bnxt_en: Remove setting of RX software timestamp

Message ID 20240906144632.404651-2-gal@nvidia.com (mailing list archive)
State Accepted
Commit 3fc85527b08c71eea2bca140e8fd939859a1cdfc
Delegated to: Netdev Maintainers
Headers show
Series RX software timestamp for all - round 3 | expand

Checks

Context Check Description
netdev/series_format fail Series longer than 15 patches
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 2 maintainers not CCed: pabeni@redhat.com edumazet@google.com
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 17 this patch: 17
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-07--06-00 (tests: 722)

Commit Message

Gal Pressman Sept. 6, 2024, 2:46 p.m. UTC 
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.

Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Michael Chan Sept. 7, 2024, 6:08 p.m. UTC | #1 
On Fri, Sep 6, 2024 at 7:46 AM Gal Pressman <gal@nvidia.com> wrote:
>
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>

Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Pavan Chebbi Sept. 8, 2024, 7:53 a.m. UTC | #2 
On Fri, Sep 6, 2024 at 8:16 PM Gal Pressman <gal@nvidia.com> wrote:
>
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index 9dadc89378f0..8fe680e691a3 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -5040,11 +5040,8 @@ static int bnxt_get_ts_info(struct net_device *dev,
>         struct bnxt_ptp_cfg *ptp;
>
>         ptp = bp->ptp_cfg;
> -       info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> -                               SOF_TIMESTAMPING_RX_SOFTWARE |
> -                               SOF_TIMESTAMPING_SOFTWARE;
> +       info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
>
> -       info->phc_index = -1;
>         if (!ptp)
>                 return 0;

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

>
> --
> 2.40.1
>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 9dadc89378f0..8fe680e691a3 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -5040,11 +5040,8 @@  static int bnxt_get_ts_info(struct net_device *dev,
 	struct bnxt_ptp_cfg *ptp;
 
 	ptp = bp->ptp_cfg;
-	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
-				SOF_TIMESTAMPING_RX_SOFTWARE |
-				SOF_TIMESTAMPING_SOFTWARE;
+	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
 
-	info->phc_index = -1;
 	if (!ptp)
 		return 0;