| Message ID | 20240909172342.487675-2-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 955f5b1508629c27682c9e5f6bad47769908b47f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: amlogic,meson-dwmac: Fix "amlogic,tx-delay-ns" schema | expand |
On Mon, Sep 9, 2024 at 7:24 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > The "amlogic,tx-delay-ns" property schema has unnecessary type reference > as it's a standard unit suffix, and the constraints are in freeform > text rather than schema. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 9 Sep 2024 12:23:42 -0500 you wrote: > The "amlogic,tx-delay-ns" property schema has unnecessary type reference > as it's a standard unit suffix, and the constraints are in freeform > text rather than schema. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > .../bindings/net/amlogic,meson-dwmac.yaml | 22 +++++++++---------- > 1 file changed, 11 insertions(+), 11 deletions(-) Here is the summary with links: - [net-next] net: amlogic,meson-dwmac: Fix "amlogic,tx-delay-ns" schema https://git.kernel.org/netdev/net-next/c/955f5b150862 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml index ee7a65b528cd..d1e2bca3c503 100644 --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml @@ -58,18 +58,18 @@ allOf: - const: timing-adjustment amlogic,tx-delay-ns: - $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 2, 4, 6] + default: 2 description: - The internal RGMII TX clock delay (provided by this driver) in - nanoseconds. Allowed values are 0ns, 2ns, 4ns, 6ns. - When phy-mode is set to "rgmii" then the TX delay should be - explicitly configured. When not configured a fallback of 2ns is - used. When the phy-mode is set to either "rgmii-id" or "rgmii-txid" - the TX clock delay is already provided by the PHY. In that case - this property should be set to 0ns (which disables the TX clock - delay in the MAC to prevent the clock from going off because both - PHY and MAC are adding a delay). - Any configuration is ignored when the phy-mode is set to "rmii". + The internal RGMII TX clock delay (provided by this driver) + in nanoseconds. When phy-mode is set to "rgmii" then the TX + delay should be explicitly configured. When the phy-mode is + set to either "rgmii-id" or "rgmii-txid" the TX clock delay + is already provided by the PHY. In that case this property + should be set to 0ns (which disables the TX clock delay in + the MAC to prevent the clock from going off because both + PHY and MAC are adding a delay). Any configuration is + ignored when the phy-mode is set to "rmii". amlogic,rx-delay-ns: deprecated: true
The "amlogic,tx-delay-ns" property schema has unnecessary type reference as it's a standard unit suffix, and the constraints are in freeform text rather than schema. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- .../bindings/net/amlogic,meson-dwmac.yaml | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-)