diff mbox series

[bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS

Message ID 20240916195919.1872371-1-ihor.solodrai@pm.me (mailing list archive)
State Accepted
Commit e4c139a63aff7e3fd6ba5afd831c63cad8dc328f
Delegated to: BPF
Headers show
Series [bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for bpf-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 10 maintainers not CCed: sdf@fomichev.me haoluo@google.com jolsa@kernel.org shuah@kernel.org linux-kselftest@vger.kernel.org song@kernel.org yonghong.song@linux.dev kpsingh@kernel.org martin.lau@linux.dev john.fastabend@gmail.com
netdev/build_clang success Errors and warnings before: 17 this patch: 17
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 22 this patch: 22
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-PR success PR summary
bpf/vmtest-bpf-next-VM_Test-1 success Logs for ShellCheck
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Unittests
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Validate matrix.py
bpf/vmtest-bpf-next-VM_Test-5 success Logs for aarch64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-0 success Logs for Lint
bpf/vmtest-bpf-next-VM_Test-4 success Logs for aarch64-gcc / build / build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-12 success Logs for s390x-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-10 success Logs for aarch64-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-6 success Logs for aarch64-gcc / test (test_maps, false, 360) / test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-9 success Logs for aarch64-gcc / test (test_verifier, false, 360) / test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-7 success Logs for aarch64-gcc / test (test_progs, false, 360) / test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-8 success Logs for aarch64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-11 success Logs for s390x-gcc / build / build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-17 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-16 success Logs for s390x-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-19 success Logs for x86_64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-18 success Logs for x86_64-gcc / build / build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-33 success Logs for x86_64-llvm-17 / veristat
bpf/vmtest-bpf-next-VM_Test-41 success Logs for x86_64-llvm-18 / veristat
bpf/vmtest-bpf-next-VM_Test-35 success Logs for x86_64-llvm-18 / build-release / build for x86_64 with llvm-18-O2
bpf/vmtest-bpf-next-VM_Test-28 success Logs for x86_64-llvm-17 / build-release / build for x86_64 with llvm-17-O2
bpf/vmtest-bpf-next-VM_Test-34 success Logs for x86_64-llvm-18 / build / build for x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-27 success Logs for x86_64-llvm-17 / build / build for x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-15 success Logs for s390x-gcc / test (test_verifier, false, 360) / test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-14 success Logs for s390x-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for s390x-gcc / test (test_progs, false, 360) / test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-25 success Logs for x86_64-gcc / test (test_verifier, false, 360) / test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-20 success Logs for x86_64-gcc / test (test_maps, false, 360) / test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-36 success Logs for x86_64-llvm-18 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-24 success Logs for x86_64-gcc / test (test_progs_parallel, true, 30) / test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-21 success Logs for x86_64-gcc / test (test_progs, false, 360) / test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-26 success Logs for x86_64-gcc / veristat / veristat on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-32 success Logs for x86_64-llvm-17 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-40 success Logs for x86_64-llvm-18 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-22 success Logs for x86_64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-29 success Logs for x86_64-llvm-17 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-23 success Logs for x86_64-gcc / test (test_progs_no_alu32_parallel, true, 30) / test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-39 success Logs for x86_64-llvm-18 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-31 success Logs for x86_64-llvm-17 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-37 success Logs for x86_64-llvm-18 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-30 success Logs for x86_64-llvm-17 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-38 success Logs for x86_64-llvm-18 / test (test_progs_cpuv4, false, 360) / test_progs_cpuv4 on x86_64 with llvm-18

Commit Message

Ihor Solodrai Sept. 16, 2024, 7:59 p.m. UTC 
test_skb_cgroup_id.sh was deleted in
https://git.kernel.org/bpf/bpf-next/c/f957c230e173

It has to be removed from TEST_PROGS variable in
tools/testing/selftests/bpf/Makefile, otherwise install target fails.

Link:
https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/

Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
---
 tools/testing/selftests/bpf/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Björn Töpel Sept. 17, 2024, 8:50 a.m. UTC | #1 
Ihor Solodrai <ihor.solodrai@pm.me> writes:

> test_skb_cgroup_id.sh was deleted in
> https://git.kernel.org/bpf/bpf-next/c/f957c230e173
>
> It has to be removed from TEST_PROGS variable in
> tools/testing/selftests/bpf/Makefile, otherwise install target fails.
>
> Link:
> https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/
>
> Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>

Tested-by: Björn Töpel <bjorn@rivosinc.com>
patchwork-bot+netdevbpf@kernel.org Sept. 24, 2024, 6:20 a.m. UTC | #2 
Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon, 16 Sep 2024 19:59:22 +0000 you wrote:
> test_skb_cgroup_id.sh was deleted in
> https://git.kernel.org/bpf/bpf-next/c/f957c230e173
> 
> It has to be removed from TEST_PROGS variable in
> tools/testing/selftests/bpf/Makefile, otherwise install target fails.
> 
> Link:
> https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS
    https://git.kernel.org/bpf/bpf-next/c/e4c139a63aff
  - [bpf-next,2/2] selftests/bpf: set vpath in Makefile to search for skels
    https://git.kernel.org/bpf/bpf-next/c/494c3a797257

You are awesome, thank you!
Matthieu Baerts (NGI0) Nov. 4, 2024, 4:31 p.m. UTC | #3 
Hi Andrii,

(+cc Geliang who reported me the issue)

On 24/09/2024 08:20, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This series was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@kernel.org>:
> 
> On Mon, 16 Sep 2024 19:59:22 +0000 you wrote:
>> test_skb_cgroup_id.sh was deleted in
>> https://git.kernel.org/bpf/bpf-next/c/f957c230e173
>>
>> It has to be removed from TEST_PROGS variable in
>> tools/testing/selftests/bpf/Makefile, otherwise install target fails.
>>
>> Link:
>> https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/

It looks like the two patches here are fixing issues that are on v6.12
as well: I'm on top of net-next, and I can see these issues. They are
fixed by these two patches that can be applied without conflicts.

In these patches, we can find references to the commits that introduced
the issues:

- Patch 1: f957c230e173 ("selftests/bpf: convert test_skb_cgroup_id_user
to test_progs")

- Patch 2: 844f7315e77a ("selftests/bpf: Use auto-dependencies for test
objects")

The two commits are in v6.12-rc1. Could it eventually be possible to
apply these two patches (with Fixes tags?) in the 'bpf' tree instead of
the 'bpf-next' one please?

> Here is the summary with links:
>   - [bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS
>     https://git.kernel.org/bpf/bpf-next/c/e4c139a63aff

Just in case, it looks like the history has been rewritten. The last ref
seems to be:

  d002b922c4d5 ("selftests/bpf: Remove test_skb_cgroup_id.sh from
TEST_PROGS")

>   - [bpf-next,2/2] selftests/bpf: set vpath in Makefile to search for skels
>     https://git.kernel.org/bpf/bpf-next/c/494c3a797257

... and:

  fd4a0e67838c ("selftests/bpf: Set vpath in Makefile to search for skels")

Thank you!

Cheers,
Matt
Andrii Nakryiko Nov. 6, 2024, 10:06 p.m. UTC | #4 
On Mon, Nov 4, 2024 at 8:31 AM Matthieu Baerts <matttbe@kernel.org> wrote:
>
> Hi Andrii,
>
> (+cc Geliang who reported me the issue)
>
> On 24/09/2024 08:20, patchwork-bot+netdevbpf@kernel.org wrote:
> > Hello:
> >
> > This series was applied to bpf/bpf-next.git (master)
> > by Andrii Nakryiko <andrii@kernel.org>:
> >
> > On Mon, 16 Sep 2024 19:59:22 +0000 you wrote:
> >> test_skb_cgroup_id.sh was deleted in
> >> https://git.kernel.org/bpf/bpf-next/c/f957c230e173
> >>
> >> It has to be removed from TEST_PROGS variable in
> >> tools/testing/selftests/bpf/Makefile, otherwise install target fails.
> >>
> >> Link:
> >> https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/
>
> It looks like the two patches here are fixing issues that are on v6.12
> as well: I'm on top of net-next, and I can see these issues. They are
> fixed by these two patches that can be applied without conflicts.
>
> In these patches, we can find references to the commits that introduced
> the issues:
>
> - Patch 1: f957c230e173 ("selftests/bpf: convert test_skb_cgroup_id_user
> to test_progs")
>
> - Patch 2: 844f7315e77a ("selftests/bpf: Use auto-dependencies for test
> objects")
>
> The two commits are in v6.12-rc1. Could it eventually be possible to
> apply these two patches (with Fixes tags?) in the 'bpf' tree instead of
> the 'bpf-next' one please?

Those patches landed back in September, more than a month ago, so it's
way too late to move them between the trees, unfortunately. You'll
probably have to do a stable backport, I'm sorry.

>
> > Here is the summary with links:
> >   - [bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS
> >     https://git.kernel.org/bpf/bpf-next/c/e4c139a63aff
>
> Just in case, it looks like the history has been rewritten. The last ref
> seems to be:
>
>   d002b922c4d5 ("selftests/bpf: Remove test_skb_cgroup_id.sh from
> TEST_PROGS")
>
> >   - [bpf-next,2/2] selftests/bpf: set vpath in Makefile to search for skels
> >     https://git.kernel.org/bpf/bpf-next/c/494c3a797257
>
> ... and:
>
>   fd4a0e67838c ("selftests/bpf: Set vpath in Makefile to search for skels")
>
> Thank you!
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index f04af11df8eb..df75f1beb731 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -132,7 +132,6 @@  TEST_PROGS := test_kmod.sh \
 	test_tunnel.sh \
 	test_lwt_seg6local.sh \
 	test_lirc_mode2.sh \
-	test_skb_cgroup_id.sh \
 	test_flow_dissector.sh \
 	test_xdp_vlan_mode_generic.sh \
 	test_xdp_vlan_mode_native.sh \