diff mbox series

selftests: netfilter: Add missing resturn value.

Message ID 20240927032205.7264-1-zhangjiao2@cmss.chinamobile.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series selftests: netfilter: Add missing resturn value. | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: linux-kselftest@vger.kernel.org
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-02--00-00 (tests: 750)

Commit Message

zhangjiao2 Sept. 27, 2024, 3:22 a.m. UTC 
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

There is no return value in count_entries, just add it.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/testing/selftests/net/netfilter/conntrack_dump_flush.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Phil Sutter Sept. 27, 2024, 11:54 a.m. UTC | #1 
On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is no return value in count_entries, just add it.
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>

Typo in $subject: resturn -> return
Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")

Apart from that:

Acked-by: Phil Sutter <phil@nwl.cc>

Thanks, Phil
Pablo Neira Ayuso Sept. 27, 2024, 11:58 a.m. UTC | #2 
On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is no return value in count_entries, just add it.

Applied, thanks
Pablo Neira Ayuso Sept. 27, 2024, 12:04 p.m. UTC | #3 
On Fri, Sep 27, 2024 at 01:54:11PM +0200, Phil Sutter wrote:
> On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > 
> > There is no return value in count_entries, just add it.
> > 
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> Typo in $subject: resturn -> return
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")

I amended this already, I found the same issues .

> Apart from that:
> 
> Acked-by: Phil Sutter <phil@nwl.cc>

But I pushed it out already without your tag, thanks for reviewing.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
index bd9317bf5ada..dc056fec993b 100644
--- a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
+++ b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
@@ -207,6 +207,7 @@  static int conntrack_data_generate_v6(struct mnl_socket *sock,
 static int count_entries(const struct nlmsghdr *nlh, void *data)
 {
 	reply_counter++;
+	return MNL_CB_OK;
 }
 
 static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone)