diff mbox series

selftests: rds: Remove include.sh when make clean

Message ID 20240927044923.12814-1-zhangjiao2@cmss.chinamobile.com (mailing list archive)
State Rejected
Delegated to: Netdev Maintainers
Headers show
Series selftests: rds: Remove include.sh when make clean | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 2 maintainers not CCed: allison.henderson@oracle.com linux-kselftest@vger.kernel.org
netdev/build_clang success Errors and warnings before: 10 this patch: 10
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn fail Errors and warnings before: 12 this patch: 12
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

zhangjiao2 Sept. 27, 2024, 4:49 a.m. UTC 
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

Remove include.sh when make clean

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/testing/selftests/net/rds/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 3, 2024, 12:23 a.m. UTC | #1 
On Fri, 27 Sep 2024 12:49:23 +0800 zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> Remove include.sh when make clean

I don't understand why. At the very least you need to improve the
commit message.
Allison Henderson Oct. 3, 2024, 10:16 p.m. UTC | #2 
On Fri, 2024-09-27 at 12:49 +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> Remove include.sh when make clean
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>

Hi Zhang,

Thanks for the patch, but it looks like Javier submitted the same fix
around the same time.  

https://patchwork.kernel.org/project/linux-rdma/patch/20240924-selftests-gitignore-v1-2-9755ac883388@gmail.com/
I've already given the rvb the other version, but thank you for
catching this anyway!

Allison

> ---
>  tools/testing/selftests/net/rds/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rds/Makefile
> b/tools/testing/selftests/net/rds/Makefile
> index da9714bc7aad..0b697669ea51 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
>         include.sh \
>         test.py
>  
> -EXTRA_CLEAN := /tmp/rds_logs
> +EXTRA_CLEAN := /tmp/rds_logs include.sh
>  
>  include ../../lib.mk
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
index da9714bc7aad..0b697669ea51 100644
--- a/tools/testing/selftests/net/rds/Makefile
+++ b/tools/testing/selftests/net/rds/Makefile
@@ -7,6 +7,6 @@  TEST_PROGS := run.sh \
 	include.sh \
 	test.py
 
-EXTRA_CLEAN := /tmp/rds_logs
+EXTRA_CLEAN := /tmp/rds_logs include.sh
 
 include ../../lib.mk