| Message ID | 20241009-airoha-fixes-v2-1-18af63ec19bf@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2518b119639162251b6cc7195aec394930c1d867 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: airoha: Fix EGRESS_RATE_METER_EN_MASK definition | expand |
On Wed, Oct 09, 2024 at 12:21:47AM +0200, Lorenzo Bianconi wrote: > Fix typo in EGRESS_RATE_METER_EN_MASK mask definition. This bus in not > introducing any user visible problem since, even if we are setting > EGRESS_RATE_METER_EN_MASK bit in REG_EGRESS_RATE_METER_CFG register, > egress QoS metering is not supported yet since we are missing some other > hw configurations (e.g token bucket rate, token bucket size). > > Introduced by commit 23020f049327 ("net: airoha: Introduce ethernet support > for EN7581 SoC") > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > Changes in v2: > - improve commit log > - Link to v1: https://lore.kernel.org/r/20241004-airoha-fixes-v1-1-2b7a01efc727@kernel.org Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 09 Oct 2024 00:21:47 +0200 you wrote: > Fix typo in EGRESS_RATE_METER_EN_MASK mask definition. This bus in not > introducing any user visible problem since, even if we are setting > EGRESS_RATE_METER_EN_MASK bit in REG_EGRESS_RATE_METER_CFG register, > egress QoS metering is not supported yet since we are missing some other > hw configurations (e.g token bucket rate, token bucket size). > > Introduced by commit 23020f049327 ("net: airoha: Introduce ethernet support > for EN7581 SoC") > > [...] Here is the summary with links: - [net-next,v2] net: airoha: Fix EGRESS_RATE_METER_EN_MASK definition https://git.kernel.org/netdev/net-next/c/2518b1196391 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c index 942fcfc5b79972e1bbda06e6e5c07302cab0affa..b3601a56bda3ec63500e0df4809102f3f0ec940f 100644 --- a/drivers/net/ethernet/mediatek/airoha_eth.c +++ b/drivers/net/ethernet/mediatek/airoha_eth.c @@ -554,7 +554,7 @@ #define FWD_DSCP_LOW_THR_MASK GENMASK(17, 0) #define REG_EGRESS_RATE_METER_CFG 0x100c -#define EGRESS_RATE_METER_EN_MASK BIT(29) +#define EGRESS_RATE_METER_EN_MASK BIT(31) #define EGRESS_RATE_METER_EQ_RATE_EN_MASK BIT(17) #define EGRESS_RATE_METER_WINDOW_SZ_MASK GENMASK(16, 12) #define EGRESS_RATE_METER_TIMESLICE_MASK GENMASK(10, 0)
Fix typo in EGRESS_RATE_METER_EN_MASK mask definition. This bus in not introducing any user visible problem since, even if we are setting EGRESS_RATE_METER_EN_MASK bit in REG_EGRESS_RATE_METER_CFG register, egress QoS metering is not supported yet since we are missing some other hw configurations (e.g token bucket rate, token bucket size). Introduced by commit 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- Changes in v2: - improve commit log - Link to v1: https://lore.kernel.org/r/20241004-airoha-fixes-v1-1-2b7a01efc727@kernel.org --- drivers/net/ethernet/mediatek/airoha_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 42b2331081178785d50d116c85ca40d728b48291 change-id: 20241004-airoha-fixes-8aaa8177b234 Best regards,