| Message ID | 20241009212319.1045176-1-aryan.srivastava@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5e7e69baaded70256fbf22391e30d17c089fa5c9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v0] net: dsa: mv88e6xxx: Fix uninitialised err value | expand |
On Thu, Oct 10, 2024 at 10:23:19AM +1300, Aryan Srivastava wrote: > The err value in mv88e6xxx_region_atu_snapshot is now potentially > uninitialised on return. Initialise err as 0. > > Fixes: ada5c3229b32 ("net: dsa: mv88e6xxx: Add FID map cache") > Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 10 Oct 2024 10:23:19 +1300 you wrote: > The err value in mv88e6xxx_region_atu_snapshot is now potentially > uninitialised on return. Initialise err as 0. > > Fixes: ada5c3229b32 ("net: dsa: mv88e6xxx: Add FID map cache") > Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz> > --- > drivers/net/dsa/mv88e6xxx/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next,v0] net: dsa: mv88e6xxx: Fix uninitialised err value https://git.kernel.org/netdev/net-next/c/5e7e69baaded You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c index ef3643bc43db..795c8df7b6a7 100644 --- a/drivers/net/dsa/mv88e6xxx/devlink.c +++ b/drivers/net/dsa/mv88e6xxx/devlink.c @@ -376,7 +376,7 @@ static int mv88e6xxx_region_atu_snapshot(struct devlink *dl, struct dsa_switch *ds = dsa_devlink_to_ds(dl); struct mv88e6xxx_devlink_atu_entry *table; struct mv88e6xxx_chip *chip = ds->priv; - int fid = -1, count, err; + int fid = -1, err = 0, count; table = kmalloc_array(mv88e6xxx_num_databases(chip), sizeof(struct mv88e6xxx_devlink_atu_entry),
The err value in mv88e6xxx_region_atu_snapshot is now potentially uninitialised on return. Initialise err as 0. Fixes: ada5c3229b32 ("net: dsa: mv88e6xxx: Add FID map cache") Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz> --- drivers/net/dsa/mv88e6xxx/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)