| Message ID | 20241010131934.1499695-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b62f4c186c70aa235fef2da68d07325d85ca3ade |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: usb: usbnet: fix race in probe failure | expand |
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 10 Oct 2024 15:19:14 +0200 you wrote: > The same bug as in the disconnect code path also exists > in the case of a failure late during the probe process. > The flag must also be set. > > Signed-off-by: Oliver Neukum <oneukum@suse.com> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > [...] Here is the summary with links: - [net] net: usb: usbnet: fix race in probe failure https://git.kernel.org/netdev/net/c/b62f4c186c70 You are awesome, thank you!
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 2506aa8c603e..ee1b5fd7b491 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1870,6 +1870,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) * may trigger an error resubmitting itself and, worse, * schedule a timer. So we kill it all just in case. */ + usbnet_mark_going_away(dev); cancel_work_sync(&dev->kevent); del_timer_sync(&dev->delay); free_netdev(net);
The same bug as in the disconnect code path also exists in the case of a failure late during the probe process. The flag must also be set. Signed-off-by: Oliver Neukum <oneukum@suse.com> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") --- drivers/net/usb/usbnet.c | 1 + 1 file changed, 1 insertion(+)