diff mbox series

[v1,net-next] rtnl_net_debug: Remove rtnl_net_debug_exit().

Message ID 20241010172433.67694-1-kuniyu@amazon.com (mailing list archive)
State Accepted
Commit bb9df28e6fcda6a96860e7b77f3912ef50e06793
Delegated to: Netdev Maintainers
Headers show
Series [v1,net-next] rtnl_net_debug: Remove rtnl_net_debug_exit(). | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 6 this patch: 6
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 6 this patch: 6
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 5 this patch: 5
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-12--12-00 (tests: 777)

Commit Message

Kuniyuki Iwashima Oct. 10, 2024, 5:24 p.m. UTC
kernel test robot reported section mismatch in rtnl_net_debug_exit().

  WARNING: modpost: vmlinux: section mismatch in reference: rtnl_net_debug_exit+0x20 (section: .exit.text) -> rtnl_net_debug_net_ops (section: .init.data)

rtnl_net_debug_exit() uses rtnl_net_debug_net_ops() that is annotated
as __net_initdata, but this file is always built-in.

Let's remove rtnl_net_debug_exit().

Fixes: 03fa53485659 ("rtnetlink: Add ASSERT_RTNL_NET() placeholder for netdev notifier.")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410101854.i0vQCaDz-lkp@intel.com/
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
 net/core/rtnl_net_debug.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 15, 2024, 11:50 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 10 Oct 2024 10:24:33 -0700 you wrote:
> kernel test robot reported section mismatch in rtnl_net_debug_exit().
> 
>   WARNING: modpost: vmlinux: section mismatch in reference: rtnl_net_debug_exit+0x20 (section: .exit.text) -> rtnl_net_debug_net_ops (section: .init.data)
> 
> rtnl_net_debug_exit() uses rtnl_net_debug_net_ops() that is annotated
> as __net_initdata, but this file is always built-in.
> 
> [...]

Here is the summary with links:
  - [v1,net-next] rtnl_net_debug: Remove rtnl_net_debug_exit().
    https://git.kernel.org/netdev/net-next/c/bb9df28e6fcd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/rtnl_net_debug.c b/net/core/rtnl_net_debug.c
index e90a32242e22..f406045cbd0e 100644
--- a/net/core/rtnl_net_debug.c
+++ b/net/core/rtnl_net_debug.c
@@ -122,10 +122,4 @@  static int __init rtnl_net_debug_init(void)
 	return ret;
 }
 
-static void __exit rtnl_net_debug_exit(void)
-{
-	unregister_netdevice_notifier(&rtnl_net_debug_block);
-	unregister_pernet_device(&rtnl_net_debug_net_ops);
-}
-
 subsys_initcall(rtnl_net_debug_init);