diff mbox series

[net-next,v2,2/2] selftests: net: move EXTRA_CLEAN of libynl.a into ynl.mk

Message ID 20241011230311.2529760-2-kuba@kernel.org (mailing list archive)
State Accepted
Commit 60b4d49b9621db4b000c9065dd6457c9a0eda80b
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v2,1/2] selftests: net: rebuild YNL if dependencies changed | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success Errors and warnings before: 0 (+0) this patch: 0 (+0)
netdev/cc_maintainers warning 2 maintainers not CCed: linux-kselftest@vger.kernel.org shuah@kernel.org
netdev/build_clang success Errors and warnings before: 4 this patch: 4
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 13 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-12--12-00 (tests: 777)

Commit Message

Jakub Kicinski Oct. 11, 2024, 11:03 p.m. UTC
Commit 1fd9e4f25782 ("selftests: make kselftest-clean remove libynl outputs")
added EXTRA_CLEAN of YNL generated files to ynl.mk. We already had
a EXTRA_CLEAN in the file including the snippet. Consolidate them.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
--
v2:
 - new patch
---
 tools/testing/selftests/net/Makefile | 1 -
 tools/testing/selftests/net/ynl.mk   | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stanislav Fomichev Oct. 11, 2024, 11:29 p.m. UTC | #1
On 10/11, Jakub Kicinski wrote:
> Commit 1fd9e4f25782 ("selftests: make kselftest-clean remove libynl outputs")
> added EXTRA_CLEAN of YNL generated files to ynl.mk. We already had
> a EXTRA_CLEAN in the file including the snippet. Consolidate them.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 649f1fe0dc46..26a4883a65c9 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -98,7 +98,6 @@  TEST_PROGS += vlan_hw_filter.sh
 TEST_PROGS += bpf_offload.py
 
 # YNL files, must be before "include ..lib.mk"
-EXTRA_CLEAN += $(OUTPUT)/libynl.a
 YNL_GEN_FILES := ncdevmem
 TEST_GEN_FILES += $(YNL_GEN_FILES)
 
diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
index add5c0cdeac4..d43afe243779 100644
--- a/tools/testing/selftests/net/ynl.mk
+++ b/tools/testing/selftests/net/ynl.mk
@@ -33,4 +33,5 @@  $(OUTPUT)/libynl.a: $(YNL_SPECS) $(OUTPUT)/.libynl-$(YNL_GENS_HASH).sig
 EXTRA_CLEAN += \
 	$(top_srcdir)/tools/net/ynl/lib/__pycache__ \
 	$(top_srcdir)/tools/net/ynl/lib/*.[ado] \
-	$(OUTPUT)/.libynl-*.sig
+	$(OUTPUT)/.libynl-*.sig \
+	$(OUTPUT)/libynl.a