diff mbox series

[net] MAINTAINERS: add Simon as an official reviewer

Message ID 20241015153005.2854018-1-kuba@kernel.org (mailing list archive)
State Accepted
Commit 9f86df0e7537c31b901b7448cf1c30f4fc1afc41
Delegated to: Netdev Maintainers
Headers show
Series [net] MAINTAINERS: add Simon as an official reviewer | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success No Fixes tags, but series doesn't touch code
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-19--00-00 (tests: 777)

Commit Message

Jakub Kicinski Oct. 15, 2024, 3:30 p.m. UTC 
Simon has been diligently and consistently reviewing networking
changes for at least as long as our development statistics
go back. Often if not usually topping the list of reviewers.
Make his role official.

Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman Oct. 16, 2024, 2:08 p.m. UTC | #1 
On Tue, Oct 15, 2024 at 08:30:05AM -0700, Jakub Kicinski wrote:
> Simon has been diligently and consistently reviewing networking
> changes for at least as long as our development statistics
> go back. Often if not usually topping the list of reviewers.
> Make his role official.
> 
> Acked-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Thanks for the kind words and trusting me with this role.
I'm happy to help.

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 20, 2024, 2:50 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by Andrew Lunn <andrew@lunn.ch>:

On Tue, 15 Oct 2024 08:30:05 -0700 you wrote:
> Simon has been diligently and consistently reviewing networking
> changes for at least as long as our development statistics
> go back. Often if not usually topping the list of reviewers.
> Make his role official.
> 
> Acked-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] MAINTAINERS: add Simon as an official reviewer
    https://git.kernel.org/netdev/net/c/9f86df0e7537

You are awesome, thank you!
Breno Leitao Nov. 1, 2024, 10:14 a.m. UTC | #3 
On Wed, Oct 16, 2024 at 03:08:01PM +0100, Simon Horman wrote:
> On Tue, Oct 15, 2024 at 08:30:05AM -0700, Jakub Kicinski wrote:
> > Simon has been diligently and consistently reviewing networking
> > changes for at least as long as our development statistics
> > go back. Often if not usually topping the list of reviewers.
> > Make his role official.
> > 
> > Acked-by: Eric Dumazet <edumazet@google.com>
> > Acked-by: Paolo Abeni <pabeni@redhat.com>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> Thanks for the kind words and trusting me with this role.
> I'm happy to help.

I'm thrilled to see this change.

Simon has been instrumental in thoroughly reviewing numerous of my
patches, and his valuable feedback has been so helpful that I've started
to include him on all my netdev patch submissions.

It's great to see this process happening automatically by default
now.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 831c72532a0b..76c8b4b5e2ab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16171,6 +16171,7 @@  M:	"David S. Miller" <davem@davemloft.net>
 M:	Eric Dumazet <edumazet@google.com>
 M:	Jakub Kicinski <kuba@kernel.org>
 M:	Paolo Abeni <pabeni@redhat.com>
+R:	Simon Horman <horms@kernel.org>
 L:	netdev@vger.kernel.org
 S:	Maintained
 P:	Documentation/process/maintainer-netdev.rst