From patchwork Fri Oct 18 20:41:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Olsa X-Patchwork-Id: 13842372 X-Patchwork-Delegate: bpf@iogearbox.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93E13209F5E; Fri, 18 Oct 2024 20:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729284202; cv=none; b=ee2s6X1xUtr7rkIZ8r0wqZ0tO4vrns5EnBjBCt7KBOUc0A4eQMyehHGt+PP4f2mpM3lrLyZiIfntqwu4Jcb2dUyDyvqI5qNrh6aODZQSDTQqUNaIx4RH4Oyt2e7MXZJ2qoHowkFHlip/RtjaLvPYVY9qUtZhUQU4AH+nldamQWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729284202; c=relaxed/simple; bh=5RL/n5Qek/9MkjgkUP42e/4QpifIj1MSiLJuLX162Xc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mPSCq3s2Srt6JG+dE3lIy80qAre+IQfL2i9cn9KkxfOFjiWOv175jvMYdOddiJhzPwSy7Z/TKjuvQVU8L8VqoMrvAvVOcrOpuvpoejnCsK3jlEJf9HFCrbwBz9TGz+NZcNT+ZUREQ8Fx4rVDs9MgpqJHw7WjNa+o4WSimQB6jPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JbBXvjZi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JbBXvjZi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E11B8C4CEC3; Fri, 18 Oct 2024 20:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729284202; bh=5RL/n5Qek/9MkjgkUP42e/4QpifIj1MSiLJuLX162Xc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JbBXvjZiqEKHf1zOwBLPwX2mBff88s31rMIXoIGEp4SzmrrVfon33aDFn2GdrsOyu U78STdqHavl3Bdvmi0d/sG9WiuU/ihXsmPvKlPfEB5h8iYR/YYs9+Bqxr/fOGrK+96 SizFU3Au2ipXvlGGnvjDupZTr/i0/GQ6ydUI65L3ZKn581sIET6A8phZ9YHFtLndRS 9M8wDIhwDs84IHz4lT6v5LwudbBxQvnAmRtQstFwfLFDQqfLR+4R+/ZPLFP+TrTrXe 7np7bmvDBlr07mr28jIzFV+1ZItbMV6+qZz79ZKzQoffRczi/LSJI128HzmqvfUMjF u39LNSTOBW3tQ== From: Jiri Olsa To: Oleg Nesterov , Peter Zijlstra , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Steven Rostedt , Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCHv8 bpf-next 10/13] selftests/bpf: Add kprobe session verifier test for return value Date: Fri, 18 Oct 2024 22:41:06 +0200 Message-ID: <20241018204109.713820-11-jolsa@kernel.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241018204109.713820-1-jolsa@kernel.org> References: <20241018204109.713820-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net Making sure kprobe.session program can return only [0,1] values. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- .../bpf/prog_tests/kprobe_multi_test.c | 2 ++ .../bpf/progs/kprobe_multi_verifier.c | 31 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c index 960c9323d1e0..66ab1cae923e 100644 --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c @@ -6,6 +6,7 @@ #include "kprobe_multi_override.skel.h" #include "kprobe_multi_session.skel.h" #include "kprobe_multi_session_cookie.skel.h" +#include "kprobe_multi_verifier.skel.h" #include "bpf/libbpf_internal.h" #include "bpf/hashmap.h" @@ -764,4 +765,5 @@ void test_kprobe_multi_test(void) test_session_skel_api(); if (test__start_subtest("session_cookie")) test_session_cookie_skel_api(); + RUN_TESTS(kprobe_multi_verifier); } diff --git a/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c b/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c new file mode 100644 index 000000000000..288577e81deb --- /dev/null +++ b/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c @@ -0,0 +1,31 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "vmlinux.h" +#include +#include +#include +#include "bpf_misc.h" + +char _license[] SEC("license") = "GPL"; + + +SEC("kprobe.session") +__success +int kprobe_session_return_0(struct pt_regs *ctx) +{ + return 0; +} + +SEC("kprobe.session") +__success +int kprobe_session_return_1(struct pt_regs *ctx) +{ + return 1; +} + +SEC("kprobe.session") +__failure +__msg("At program exit the register R0 has smin=2 smax=2 should have been in [0, 1]") +int kprobe_session_return_2(struct pt_regs *ctx) +{ + return 2; +}