| Message ID | 20241023164840.140535-1-csander@purestorage.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" | expand |
On Wed, Oct 23, 2024 at 10:48:38AM -0600, Caleb Sander Mateos wrote: > "enahnced" looks to be a misspelling of "enhanced". > Rename "mlx5_cqwq_get_cqe_enahnced_comp" to > "mlx5_cqwq_get_cqe_enhanced_comp". > > Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> Reviewed-by: Simon Horman <horms@kernel.org>
On 23/10/2024 19:48, Caleb Sander Mateos wrote: > "enahnced" looks to be a misspelling of "enhanced". Indeed. > Rename "mlx5_cqwq_get_cqe_enahnced_comp" to > "mlx5_cqwq_get_cqe_enhanced_comp". > > Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> > --- Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Thanks.
On Wed, Oct 23, 2024 at 10:19 PM Caleb Sander Mateos <csander@purestorage.com> wrote: > > "enahnced" looks to be a misspelling of "enhanced". > Rename "mlx5_cqwq_get_cqe_enahnced_comp" to > "mlx5_cqwq_get_cqe_enhanced_comp". > > Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> LGTM, Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
On Wed, 23 Oct 2024 10:48:38 -0600 Caleb Sander Mateos wrote: > "enahnced" looks to be a misspelling of "enhanced". > Rename "mlx5_cqwq_get_cqe_enahnced_comp" to > "mlx5_cqwq_get_cqe_enhanced_comp". Applied, thanks!
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index e601324a690a..604c0a72aa6c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -1124,11 +1124,11 @@ static void mlx5e_flush_rq_cq(struct mlx5e_rq *rq) { struct mlx5_cqwq *cqwq = &rq->cq.wq; struct mlx5_cqe64 *cqe; if (test_bit(MLX5E_RQ_STATE_MINI_CQE_ENHANCED, &rq->state)) { - while ((cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq))) + while ((cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq))) mlx5_cqwq_pop(cqwq); } else { while ((cqe = mlx5_cqwq_get_cqe(cqwq))) mlx5_cqwq_pop(cqwq); } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 8e24ba96c779..d81083f4f316 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -2434,11 +2434,11 @@ static int mlx5e_rx_cq_process_enhanced_cqe_comp(struct mlx5e_rq *rq, { struct mlx5_cqe64 *cqe, *title_cqe = NULL; struct mlx5e_cq_decomp *cqd = &rq->cqd; int work_done = 0; - cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq); + cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq); if (!cqe) return work_done; if (cqd->last_cqe_title && (mlx5_get_cqe_format(cqe) == MLX5_COMPRESSED)) { @@ -2464,11 +2464,11 @@ static int mlx5e_rx_cq_process_enhanced_cqe_comp(struct mlx5e_rq *rq, INDIRECT_CALL_3(rq->handle_rx_cqe, mlx5e_handle_rx_cqe_mpwrq, mlx5e_handle_rx_cqe, mlx5e_handle_rx_cqe_mpwrq_shampo, rq, cqe); work_done++; } while (work_done < budget_rem && - (cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq))); + (cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq))); /* last cqe might be title on next poll bulk */ if (title_cqe) { mlx5e_read_enhanced_title_slot(rq, title_cqe); cqd->last_cqe_title = true; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.h b/drivers/net/ethernet/mellanox/mlx5/core/wq.h index e4ef1d24a3ad..6debb8fd33ff 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/wq.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/wq.h @@ -242,11 +242,11 @@ static inline struct mlx5_cqe64 *mlx5_cqwq_get_cqe(struct mlx5_cqwq *wq) return cqe; } static inline -struct mlx5_cqe64 *mlx5_cqwq_get_cqe_enahnced_comp(struct mlx5_cqwq *wq) +struct mlx5_cqe64 *mlx5_cqwq_get_cqe_enhanced_comp(struct mlx5_cqwq *wq) { u8 sw_validity_iteration_count = mlx5_cqwq_get_wrap_cnt(wq) & 0xff; u32 ci = mlx5_cqwq_get_ci(wq); struct mlx5_cqe64 *cqe;
"enahnced" looks to be a misspelling of "enhanced". Rename "mlx5_cqwq_get_cqe_enahnced_comp" to "mlx5_cqwq_get_cqe_enhanced_comp". Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/wq.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)