| Message ID | 20241025161415.238215-1-leitao@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net: netconsole: selftests: Change the IP subnet | expand |
Breno Leitao <leitao@debian.org> writes: > Use a less populated IP range to run the tests, as suggested by Petr in > Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. > > Suggested-by: Petr Machata <petrm@nvidia.com> > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh > index 06021b2059b7..4ad1e216c6b0 100755 > --- a/tools/testing/selftests/drivers/net/netcons_basic.sh > +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh > @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")") > > # Simple script to test dynamic targets in netconsole > SRCIF="" # to be populated later > -SRCIP=192.168.1.1 > +SRCIP=192.168.2.1 I mentioned 192.0.2.0/24, which we commonly use in selftests. The range is meant for examples and documentation, which is not exactly selftests, but feels like it's not bending the rules too far. And we shouldn't see the range in the wild. > DSTIF="" # to be populated later > -DSTIP=192.168.1.2 > +DSTIP=192.168.2.2 > > PORT="6666" > MSG="netconsole selftest"
On Fri, Oct 25, 2024 at 07:01:59PM +0200, Petr Machata wrote: > > Breno Leitao <leitao@debian.org> writes: > > > Use a less populated IP range to run the tests, as suggested by Petr in > > Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. > > > > Suggested-by: Petr Machata <petrm@nvidia.com> > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh > > index 06021b2059b7..4ad1e216c6b0 100755 > > --- a/tools/testing/selftests/drivers/net/netcons_basic.sh > > +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh > > @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")") > > > > # Simple script to test dynamic targets in netconsole > > SRCIF="" # to be populated later > > -SRCIP=192.168.1.1 > > +SRCIP=192.168.2.1 > > I mentioned 192.0.2.0/24, which we commonly use in selftests. The range > is meant for examples and documentation, which is not exactly selftests, > but feels like it's not bending the rules too far. And we shouldn't see > the range in the wild. True, my mistake. I will update it to 192.0.2.1 and 192.0.2.2.
diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh index 06021b2059b7..4ad1e216c6b0 100755 --- a/tools/testing/selftests/drivers/net/netcons_basic.sh +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")") # Simple script to test dynamic targets in netconsole SRCIF="" # to be populated later -SRCIP=192.168.1.1 +SRCIP=192.168.2.1 DSTIF="" # to be populated later -DSTIP=192.168.1.2 +DSTIP=192.168.2.2 PORT="6666" MSG="netconsole selftest"
Use a less populated IP range to run the tests, as suggested by Petr in Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. Suggested-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Breno Leitao <leitao@debian.org> --- tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)