diff mbox series

[net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value

Message ID 20241028091214.2078726-1-suraj.gupta2@amd.com (mailing list archive)
State Accepted
Commit b2183187c5fd30659b9caccb92f7e5e680301769
Delegated to: Netdev Maintainers
Headers show
Series [net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers fail 1 blamed authors not CCed: sarath.babu.naidu.gaddam@amd.com; 2 maintainers not CCed: sarath.babu.naidu.gaddam@amd.com radhey.shyam.pandey@xilinx.com
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-31--09-00 (tests: 779)

Commit Message

Gupta, Suraj Oct. 28, 2024, 9:12 a.m. UTC 
Correct phy-mode property value to 1000base-x.

Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
---
 Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pandey, Radhey Shyam Oct. 30, 2024, 6:12 a.m. UTC | #1 
> -----Original Message-----
> From: Suraj Gupta <suraj.gupta2@amd.com>
> Sent: Monday, October 28, 2024 2:42 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: git (AMD-Xilinx) <git@amd.com>; Katakam, Harini <harini.katakam@amd.com>
> Subject: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property
> value
> 
> Correct phy-mode property value to 1000base-x.
> 
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document
> to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
>  Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> index e95c21628281..fb02e579463c 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> @@ -61,7 +61,7 @@ properties:
>        - gmii
>        - rgmii
>        - sgmii
> -      - 1000BaseX
> +      - 1000base-x
> 
>    xlnx,phy-type:
>      description:
> --
> 2.25.1
Andrew Lunn Oct. 30, 2024, 1:35 p.m. UTC | #2 
On Wed, Oct 30, 2024 at 06:12:37AM +0000, Pandey, Radhey Shyam wrote:
> > -----Original Message-----
> > From: Suraj Gupta <suraj.gupta2@amd.com>
> > Sent: Monday, October 28, 2024 2:42 PM
> > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>;
> > andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> > conor+dt@kernel.org; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Cc: git (AMD-Xilinx) <git@amd.com>; Katakam, Harini <harini.katakam@amd.com>
> > Subject: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property
> > value
> > 
> > Correct phy-mode property value to 1000base-x.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Jakub Kicinski Nov. 1, 2024, 1:53 a.m. UTC | #3 
On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> Correct phy-mode property value to 1000base-x.
> 
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> ---
>  Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> index e95c21628281..fb02e579463c 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> @@ -61,7 +61,7 @@ properties:
>        - gmii
>        - rgmii
>        - sgmii
> -      - 1000BaseX
> +      - 1000base-x
>  
>    xlnx,phy-type:
>      description:

Can we get an ack from DT folks?
Conor Dooley Nov. 1, 2024, 5:14 p.m. UTC | #4 
On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > Correct phy-mode property value to 1000base-x.
> > 
> > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> > ---
> >  Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > index e95c21628281..fb02e579463c 100644
> > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > @@ -61,7 +61,7 @@ properties:
> >        - gmii
> >        - rgmii
> >        - sgmii
> > -      - 1000BaseX
> > +      - 1000base-x
> >  
> >    xlnx,phy-type:
> >      description:
> 
> Can we get an ack from DT folks?

I dunno, the commit message gives no detail at all about the impact of
changing this, so I don't want to ack it. I *assume* that this is parsed
by common code and 1000BaseX is not understood by that common code,
but...
Rob Herring (Arm) Nov. 1, 2024, 5:34 p.m. UTC | #5 
On Fri, Nov 01, 2024 at 05:14:50PM +0000, Conor Dooley wrote:
> On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> > On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > > Correct phy-mode property value to 1000base-x.
> > > 
> > > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > > Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> > > ---
> > >  Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > index e95c21628281..fb02e579463c 100644
> > > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > @@ -61,7 +61,7 @@ properties:
> > >        - gmii
> > >        - rgmii
> > >        - sgmii
> > > -      - 1000BaseX
> > > +      - 1000base-x
> > >  
> > >    xlnx,phy-type:
> > >      description:
> > 
> > Can we get an ack from DT folks?
> 
> I dunno, the commit message gives no detail at all about the impact of
> changing this, so I don't want to ack it. I *assume* that this is parsed
> by common code and 1000BaseX is not understood by that common code,
> but...

We're the ones defining the names in ethernet-controller.yaml. It should 
also have failed validation if used because the list here must be a 
subset of that list. So nothing to do with whatever the kernel does.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
patchwork-bot+netdevbpf@kernel.org Nov. 2, 2024, 2:20 a.m. UTC | #6 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 28 Oct 2024 14:42:14 +0530 you wrote:
> Correct phy-mode property value to 1000base-x.
> 
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> ---
>  Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
    https://git.kernel.org/netdev/net/c/b2183187c5fd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
index e95c21628281..fb02e579463c 100644
--- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
+++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
@@ -61,7 +61,7 @@  properties:
       - gmii
       - rgmii
       - sgmii
-      - 1000BaseX
+      - 1000base-x
 
   xlnx,phy-type:
     description: