diff mbox series

[v4,net-next,3/3] devlink: Add documenation for OcteonTx2 AF

Message ID 20241029035739.1981839-4-lcherian@marvell.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Knobs for NPC default rule counters | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 2 maintainers not CCed: horms@kernel.org pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 21 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-31--09-00 (tests: 779)

Commit Message

Linu Cherian Oct. 29, 2024, 3:57 a.m. UTC
Add documenation for the following devlink params
- npc_mcam_high_zone_percent
- npc_def_rule_cntr
- nix_maxlf

Signed-off-by: Linu Cherian <lcherian@marvell.com>
---
Changelog from v3:
Newly added patch

 Documentation/networking/devlink/octeontx2.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Simon Horman Nov. 2, 2024, 2:52 p.m. UTC | #1
On Tue, Oct 29, 2024 at 09:27:39AM +0530, Linu Cherian wrote:
> Add documenation for the following devlink params
> - npc_mcam_high_zone_percent
> - npc_def_rule_cntr
> - nix_maxlf
> 
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
> Changelog from v3:
> Newly added patch

Thanks for addressing this, much appreciated.

Reviewed-by: Simon Horman <horms@kernel.org>
Jakub Kicinski Nov. 3, 2024, 7:55 p.m. UTC | #2
On Tue, 29 Oct 2024 09:27:39 +0530 Linu Cherian wrote:
> +   * - ``npc_def_rule_cntr``
> +     - bool
> +     - runtime
> +     - Use to enable or disable hit counters for the default rules in NPC MCAM.

How are those counters accessible? ethtool -S? debugfs ? it should be
documented here. Plus please add examples of what such rules cover.
"default rules in NPC MCAM" requires too much familiarity with the
device.
Linu Cherian Nov. 4, 2024, 10:33 a.m. UTC | #3
Hi Jakub,

On 2024-11-04 at 01:25:48, Jakub Kicinski (kuba@kernel.org) wrote:
> On Tue, 29 Oct 2024 09:27:39 +0530 Linu Cherian wrote:
> > +   * - ``npc_def_rule_cntr``
> > +     - bool
> > +     - runtime
> > +     - Use to enable or disable hit counters for the default rules in NPC MCAM.
> 
> How are those counters accessible? ethtool -S? debugfs ? it should be
> documented here. Plus please add examples of what such rules cover.
> "default rules in NPC MCAM" requires too much familiarity with the
> device.

Ack. Will address this.
diff mbox series

Patch

diff --git a/Documentation/networking/devlink/octeontx2.rst b/Documentation/networking/devlink/octeontx2.rst
index d33a90dd44bf..7808ab361692 100644
--- a/Documentation/networking/devlink/octeontx2.rst
+++ b/Documentation/networking/devlink/octeontx2.rst
@@ -40,6 +40,21 @@  The ``octeontx2 AF`` driver implements the following driver-specific parameters.
      - runtime
      - Use to set the quantum which hardware uses for scheduling among transmit queues.
        Hardware uses weighted DWRR algorithm to schedule among all transmit queues.
+   * - ``npc_mcam_high_zone_percent``
+     - u8
+     - runtime
+     - Use to set the number of high priority zone entries in NPC MCAM that can be allocated
+       by a user, out of the three priority zone categories high, mid and low.
+   * - ``npc_def_rule_cntr``
+     - bool
+     - runtime
+     - Use to enable or disable hit counters for the default rules in NPC MCAM.
+   * - ``nix_maxlf``
+     - u16
+     - runtime
+     - Use to set the maximum number of LFs in NIX hardware block. This would be useful
+       to increase the availability of default resources allocated to enabled LFs like
+       MCAM entries for example.
 
 The ``octeontx2 PF`` driver implements the following driver-specific parameters.