| Message ID | 20241102151625.39535-3-linux@treblig.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 70e58249a6468fd98575da52ad83f7a29634377c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | A pile of sfc deadcode | expand |
On Sat, Nov 02, 2024 at 03:16:23PM +0000, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > efx_mae_mport_vf() has been unused since > commit 5227adff37af ("sfc: add mport lookup based on driver's mport data") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Acked-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > drivers/net/ethernet/sfc/mae.c | 11 ----------- > drivers/net/ethernet/sfc/mae.h | 1 - > 2 files changed, 12 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c > index 10709d828a63..50f097487b14 100644 > --- a/drivers/net/ethernet/sfc/mae.c > +++ b/drivers/net/ethernet/sfc/mae.c > @@ -76,17 +76,6 @@ void efx_mae_mport_uplink(struct efx_nic *efx __always_unused, u32 *out) > *out = EFX_DWORD_VAL(mport); > } > > -void efx_mae_mport_vf(struct efx_nic *efx __always_unused, u32 vf_id, u32 *out) > -{ > - efx_dword_t mport; > - > - EFX_POPULATE_DWORD_3(mport, > - MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_FUNC, > - MAE_MPORT_SELECTOR_FUNC_PF_ID, MAE_MPORT_SELECTOR_FUNC_PF_ID_CALLER, > - MAE_MPORT_SELECTOR_FUNC_VF_ID, vf_id); > - *out = EFX_DWORD_VAL(mport); > -} > - > /* Constructs an mport selector from an mport ID, because they're not the same */ > void efx_mae_mport_mport(struct efx_nic *efx __always_unused, u32 mport_id, u32 *out) > { > diff --git a/drivers/net/ethernet/sfc/mae.h b/drivers/net/ethernet/sfc/mae.h > index 8df30bc4f3ba..db79912c86d8 100644 > --- a/drivers/net/ethernet/sfc/mae.h > +++ b/drivers/net/ethernet/sfc/mae.h > @@ -23,7 +23,6 @@ int efx_mae_free_mport(struct efx_nic *efx, u32 id); > > void efx_mae_mport_wire(struct efx_nic *efx, u32 *out); > void efx_mae_mport_uplink(struct efx_nic *efx, u32 *out); > -void efx_mae_mport_vf(struct efx_nic *efx, u32 vf_id, u32 *out); > void efx_mae_mport_mport(struct efx_nic *efx, u32 mport_id, u32 *out); > > int efx_mae_lookup_mport(struct efx_nic *efx, u32 selector, u32 *id); > -- > 2.47.0 >
diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c index 10709d828a63..50f097487b14 100644 --- a/drivers/net/ethernet/sfc/mae.c +++ b/drivers/net/ethernet/sfc/mae.c @@ -76,17 +76,6 @@ void efx_mae_mport_uplink(struct efx_nic *efx __always_unused, u32 *out) *out = EFX_DWORD_VAL(mport); } -void efx_mae_mport_vf(struct efx_nic *efx __always_unused, u32 vf_id, u32 *out) -{ - efx_dword_t mport; - - EFX_POPULATE_DWORD_3(mport, - MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_FUNC, - MAE_MPORT_SELECTOR_FUNC_PF_ID, MAE_MPORT_SELECTOR_FUNC_PF_ID_CALLER, - MAE_MPORT_SELECTOR_FUNC_VF_ID, vf_id); - *out = EFX_DWORD_VAL(mport); -} - /* Constructs an mport selector from an mport ID, because they're not the same */ void efx_mae_mport_mport(struct efx_nic *efx __always_unused, u32 mport_id, u32 *out) { diff --git a/drivers/net/ethernet/sfc/mae.h b/drivers/net/ethernet/sfc/mae.h index 8df30bc4f3ba..db79912c86d8 100644 --- a/drivers/net/ethernet/sfc/mae.h +++ b/drivers/net/ethernet/sfc/mae.h @@ -23,7 +23,6 @@ int efx_mae_free_mport(struct efx_nic *efx, u32 id); void efx_mae_mport_wire(struct efx_nic *efx, u32 *out); void efx_mae_mport_uplink(struct efx_nic *efx, u32 *out); -void efx_mae_mport_vf(struct efx_nic *efx, u32 vf_id, u32 *out); void efx_mae_mport_mport(struct efx_nic *efx, u32 mport_id, u32 *out); int efx_mae_lookup_mport(struct efx_nic *efx, u32 selector, u32 *id);