From patchwork Sat Nov 9 01:30:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacob Keller X-Patchwork-Id: 13869141 X-Patchwork-Delegate: kuba@kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63BE6233D85; Sat, 9 Nov 2024 01:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731115837; cv=none; b=WBN+Tw6nyH9h93hSCZAiLVBxKKhlDFbq0azqTRGmmiSVIK5CrTv5+t5HJY18XvxEvpj7E8bjHsrML7EDeYDhW/obBYkHaQWiqCpRDGm7HUk+oPNXdkzM8vTbrLLj+QsAY0Gm+y44EQeiMtTY2+YclIdZJQDoZPEJnElJ3NNJOs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731115837; c=relaxed/simple; bh=smdCnKK5JCnXzm+UfTq+T7poKVvmdHV4Efr4cxIXJpQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WYVqCoF1qRk0D9iATJXlWCge4zJvchc4uxDg2G9pIDNHRAnbLT9i8xE6twDzRRa4B1W8R0MA7WKciSumN//gCXKcnTe4Z82JhGwx1g8rwan2P29DAOT3tUsqJAxW17nEK979fkM9DbGtiVzlDVYEjXj+kD1Lf2GSG17fIdqZSto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Cmdi2kyE; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Cmdi2kyE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731115835; x=1762651835; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=smdCnKK5JCnXzm+UfTq+T7poKVvmdHV4Efr4cxIXJpQ=; b=Cmdi2kyEkexE57Oapqju5TIHJ7IaVg1F0sxvYifIgMVWlY08IZ6YhUkB sNPrRG3SFSsj5IrhvWIGrflgdFCv5bJlkz+mG/bvcPkv4YFLBK0TqZXW6 cABTBtuA0mFaN7efDnSleksc23sUxPP34p/ElfV/fmVlxNbYG3lO+7IV9 2DTVbOaHW0OxFTkwNf9xoY30M/2jQYs2SLBI0jzy2QwOc9mPHcrHkMn7A ZJSJi5c8K4WjAF8z0lTZJoSTVduoB1t6qApzqKGbQFB1Vv7i2BCu+pkcK ocAwU7cPyLzstjc39Njhz12hDUamqGvuCjvvul01FvCqUdCCKz2uHTOWg w==; X-CSE-ConnectionGUID: JdwdTv41QO2t5QCpIPYjsg== X-CSE-MsgGUID: iBIc/FvkRQGxHUqWC/xbcg== X-IronPort-AV: E=McAfee;i="6700,10204,11250"; a="18637304" X-IronPort-AV: E=Sophos;i="6.12,139,1728975600"; d="scan'208";a="18637304" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2024 17:30:33 -0800 X-CSE-ConnectionGUID: 6d2vHT5cQm2obJN6PK+2BQ== X-CSE-MsgGUID: E6vRIpIWTgS0+YL9JBafyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="90646179" Received: from jekeller-desk.jf.intel.com ([10.166.241.20]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2024 17:30:33 -0800 From: Jacob Keller Date: Fri, 08 Nov 2024 17:30:17 -0800 Subject: [PATCH net-next v4 4/9] ice: remove int_q_state from ice_tlan_ctx Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241108-packing-pack-fields-and-ice-implementation-v4-4-81a9f42c30e5@intel.com> References: <20241108-packing-pack-fields-and-ice-implementation-v4-0-81a9f42c30e5@intel.com> In-Reply-To: <20241108-packing-pack-fields-and-ice-implementation-v4-0-81a9f42c30e5@intel.com> To: Vladimir Oltean , Andrew Morton , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Masahiro Yamada , netdev Cc: linux-kbuild@vger.kernel.org, Jacob Keller X-Mailer: b4 0.14.1 X-Patchwork-Delegate: kuba@kernel.org The int_q_state field of the ice_tlan_ctx structure represents the internal queue state. However, we never actually need to assign this or read this during normal operation. In fact, trying to unpack it would not be possible as it is larger than a u64. Remove this field from the ice_tlan_ctx structure, and remove its packing field from the ice_tlan_ctx_info array. Signed-off-by: Jacob Keller Reviewed-by: Przemek Kitszel --- drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 1 - drivers/net/ethernet/intel/ice/ice_common.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h index 611577ebc29d..0e8ed8c226e6 100644 --- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h +++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h @@ -590,7 +590,6 @@ struct ice_tlan_ctx { u8 drop_ena; u8 cache_prof_idx; u8 pkt_shaper_prof_idx; - u8 int_q_state; /* width not needed - internal - DO NOT WRITE!!! */ }; #endif /* _ICE_LAN_TX_RX_H_ */ diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index b22e71dc59d4..0f5a80269a7b 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -1467,7 +1467,6 @@ const struct ice_ctx_ele ice_tlan_ctx_info[] = { ICE_CTX_STORE(ice_tlan_ctx, drop_ena, 1, 165), ICE_CTX_STORE(ice_tlan_ctx, cache_prof_idx, 2, 166), ICE_CTX_STORE(ice_tlan_ctx, pkt_shaper_prof_idx, 3, 168), - ICE_CTX_STORE(ice_tlan_ctx, int_q_state, 122, 171), { 0 } };