| Message ID | 20241112105430.438491-1-alistair@alistair23.me (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e7cb7cf43afb96a4fd8f68c2dfb9b2fbdd444654 |
| Headers | show |
| Series | [1/2] include: mdio: Remove mdio45_ethtool_gset() | expand |
On Tue, Nov 12, 2024 at 08:54:29PM +1000, Alistair Francis wrote: > From: Alistair Francis <alistair.francis@wdc.com> > > mdio45_ethtool_gset() is never called, so let's remove it. > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> With a pathchset, it would be normal to include a cover node, patch 0/X, which explains the big picture. There you could mention that you are primarily doing this for Rust since it gives linker errors. The patches themselves look O.K. Lets leave them for a couple of days so 0-day can build test them and see if there are some users hiding away which we both missed. Andrew
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 12 Nov 2024 20:54:29 +1000 you wrote: > From: Alistair Francis <alistair.francis@wdc.com> > > mdio45_ethtool_gset() is never called, so let's remove it. > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > include/linux/mdio.h | 16 ---------------- > 1 file changed, 16 deletions(-) Here is the summary with links: - [1/2] include: mdio: Remove mdio45_ethtool_gset() https://git.kernel.org/netdev/net-next/c/e7cb7cf43afb - [2/2] mdio: Remove mdio45_ethtool_gset_npage() https://git.kernel.org/netdev/net-next/c/575092a7f0ce You are awesome, thank you!
diff --git a/include/linux/mdio.h b/include/linux/mdio.h index efeca5bd7600..c63f43645d50 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -173,22 +173,6 @@ mdio45_ethtool_ksettings_get_npage(const struct mdio_if_info *mdio, struct ethtool_link_ksettings *cmd, u32 npage_adv, u32 npage_lpa); -/** - * mdio45_ethtool_gset - get settings for ETHTOOL_GSET - * @mdio: MDIO interface - * @ecmd: Ethtool request structure - * - * Since the CSRs for auto-negotiation using next pages are not fully - * standardised, this function does not attempt to decode them. Use - * mdio45_ethtool_gset_npage() to specify advertisement bits from next - * pages. - */ -static inline void mdio45_ethtool_gset(const struct mdio_if_info *mdio, - struct ethtool_cmd *ecmd) -{ - mdio45_ethtool_gset_npage(mdio, ecmd, 0, 0); -} - /** * mdio45_ethtool_ksettings_get - get settings for ETHTOOL_GLINKSETTINGS * @mdio: MDIO interface