| Message ID | 20241114151946.519047-1-dmantipov@yandex.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e64285ff41bb7a934bd815bd38f31119be62ac37 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | rocker: fix link status detection in rocker_carrier_init() | expand |
On Thu, 14 Nov 2024 18:19:46 +0300 Dmitry Antipov wrote: > Since '1 << rocker_port->pport' may be undefined for port >= 32, > cast the left operand to 'unsigned long long' like it's done in > 'rocker_port_set_enable()' above. Compile tested only. Jiri, random thought - any sense if anyone still uses rocker? IIUC the goal was similar to netdevsim - SW testing / modeling but we don't really have any upstream tests against it.. Unrelated to the patch, so dropping the author from CC.
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 14 Nov 2024 18:19:46 +0300 you wrote: > Since '1 << rocker_port->pport' may be undefined for port >= 32, > cast the left operand to 'unsigned long long' like it's done in > 'rocker_port_set_enable()' above. Compile tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> > > [...] Here is the summary with links: - rocker: fix link status detection in rocker_carrier_init() https://git.kernel.org/netdev/net-next/c/e64285ff41bb You are awesome, thank you!
Tue, Nov 19, 2024 at 03:42:01AM CET, kuba@kernel.org wrote: >On Thu, 14 Nov 2024 18:19:46 +0300 Dmitry Antipov wrote: >> Since '1 << rocker_port->pport' may be undefined for port >= 32, >> cast the left operand to 'unsigned long long' like it's done in >> 'rocker_port_set_enable()' above. Compile tested only. > >Jiri, random thought - any sense if anyone still uses rocker? >IIUC the goal was similar to netdevsim - SW testing / modeling >but we don't really have any upstream tests against it.. Afaik some people are still using it for testing. I got couple emails in the past. Not sure now. The thing is, rocker has real datapath, comparing to netdevsim. > >Unrelated to the patch, so dropping the author from CC.
diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index 84fa911c78db..fe0bf1d3217a 100644 --- a/drivers/net/ethernet/rocker/rocker_main.c +++ b/drivers/net/ethernet/rocker/rocker_main.c @@ -2502,7 +2502,7 @@ static void rocker_carrier_init(const struct rocker_port *rocker_port) u64 link_status = rocker_read64(rocker, PORT_PHYS_LINK_STATUS); bool link_up; - link_up = link_status & (1 << rocker_port->pport); + link_up = link_status & (1ULL << rocker_port->pport); if (link_up) netif_carrier_on(rocker_port->dev); else
Since '1 << rocker_port->pport' may be undefined for port >= 32, cast the left operand to 'unsigned long long' like it's done in 'rocker_port_set_enable()' above. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> --- drivers/net/ethernet/rocker/rocker_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)