| Message ID | 20241115-converge-secs-to-jiffies-v2-1-911fb7595e79@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Converge on using secs_to_jiffies() | expand |
Hi Easwar, On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan <eahariha@linux.microsoft.com> wrote: > > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, > - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, > - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, > + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), > + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), > + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), You have changed this last timeout from 30 seconds to 3 (presumably just a copy and paste error).
On 11/15/2024 2:34 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan <eahariha@linux.microsoft.com> wrote: >> >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> - [SCTP_CONNTRACK_CLOSED] = 10 SECS, >> - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, >> - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, >> - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, >> + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), >> + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), >> + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), > > You have changed this last timeout from 30 seconds to 3 (presumably > just a copy and paste error). > Will fix in v3.
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > None of the higher order definitions are used anymore, so remove > definitions for minutes, hours, and days timeouts. Convert the seconds > denominated timeouts to secs_to_jiffies() There is very similar things with tcp_timeouts[] in nf_conntrack_proto_tcp.c, why not convert it as well ? > > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c > index 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 > --- a/net/netfilter/nf_conntrack_proto_sctp.c > +++ b/net/netfilter/nf_conntrack_proto_sctp.c > @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { > [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", > }; > > -#define SECS * HZ > -#define MINS * 60 SECS > -#define HOURS * 60 MINS > -#define DAYS * 24 HOURS > - > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, > - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, > - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, > + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), > + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), > + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), Was 30 before, if you think it must be changed to 3 you must explain it in the commit message, or maybe do another patch for that change. > }; > > #define SCTP_FLAG_HEARTBEAT_VTAG_FAILED 1 > > -- > 2.34.1 > Christophe
Hi Easwar, kernel test robot noticed the following build errors: [auto build test ERROR on 2d5404caa8c7bb5c4e0435f94b28834ae5456623] url: https://github.com/intel-lab-lkp/linux/commits/Easwar-Hariharan/netfilter-conntrack-Cleanup-timeout-definitions/20241117-003530 base: 2d5404caa8c7bb5c4e0435f94b28834ae5456623 patch link: https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v2-1-911fb7595e79%40linux.microsoft.com patch subject: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241118/202411180131.xdHcVFlh-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241118/202411180131.xdHcVFlh-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411180131.xdHcVFlh-lkp@intel.com/ All errors (new ones prefixed by >>): >> net/netfilter/nf_conntrack_proto_sctp.c:43:51: error: implicit declaration of function 'secs_to_jiffies'; did you mean 'nsecs_to_jiffies'? [-Werror=implicit-function-declaration] 43 | [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), | ^~~~~~~~~~~~~~~ | nsecs_to_jiffies >> net/netfilter/nf_conntrack_proto_sctp.c:43:51: error: initializer element is not constant net/netfilter/nf_conntrack_proto_sctp.c:43:51: note: (near initialization for 'sctp_timeouts[1]') net/netfilter/nf_conntrack_proto_sctp.c:44:51: error: initializer element is not constant 44 | [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:44:51: note: (near initialization for 'sctp_timeouts[2]') net/netfilter/nf_conntrack_proto_sctp.c:45:51: error: initializer element is not constant 45 | [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:45:51: note: (near initialization for 'sctp_timeouts[3]') net/netfilter/nf_conntrack_proto_sctp.c:46:51: error: initializer element is not constant 46 | [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:46:51: note: (near initialization for 'sctp_timeouts[4]') net/netfilter/nf_conntrack_proto_sctp.c:47:51: error: initializer element is not constant 47 | [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:47:51: note: (near initialization for 'sctp_timeouts[5]') net/netfilter/nf_conntrack_proto_sctp.c:48:51: error: initializer element is not constant 48 | [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:48:51: note: (near initialization for 'sctp_timeouts[6]') net/netfilter/nf_conntrack_proto_sctp.c:49:51: error: initializer element is not constant 49 | [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:49:51: note: (near initialization for 'sctp_timeouts[7]') net/netfilter/nf_conntrack_proto_sctp.c:50:51: error: initializer element is not constant 50 | [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), | ^~~~~~~~~~~~~~~ net/netfilter/nf_conntrack_proto_sctp.c:50:51: note: (near initialization for 'sctp_timeouts[8]') cc1: some warnings being treated as errors vim +43 net/netfilter/nf_conntrack_proto_sctp.c 41 42 static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > 43 [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), 44 [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), 45 [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), 46 [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), 47 [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), 48 [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), 49 [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), 50 [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), 51 }; 52
On 11/16/2024 1:40 AM, Christophe Leroy wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de >> eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> None of the higher order definitions are used anymore, so remove >> definitions for minutes, hours, and days timeouts. Convert the seconds >> denominated timeouts to secs_to_jiffies() > > There is very similar things with tcp_timeouts[] in > nf_conntrack_proto_tcp.c, why not convert it as well ? This patch happens to have been hand-modified and not by Coccinelle. I'll consider tcp_timeouts[] for v3, but that actually seems to have minute, hour, and days denominated timeouts, and replacing the 4 SECS timeouts may actually hinder readability in that file. > >> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> >> --- >> net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- >> 1 file changed, 8 insertions(+), 13 deletions(-) >> >> diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/ >> nf_conntrack_proto_sctp.c >> index >> 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 >> --- a/net/netfilter/nf_conntrack_proto_sctp.c >> +++ b/net/netfilter/nf_conntrack_proto_sctp.c >> @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { >> [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", >> }; >> >> -#define SECS * HZ >> -#define MINS * 60 SECS >> -#define HOURS * 60 MINS >> -#define DAYS * 24 HOURS >> - >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> - [SCTP_CONNTRACK_CLOSED] = 10 SECS, >> - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, >> - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, >> - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, >> + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), >> + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), >> + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), > > Was 30 before, if you think it must be changed to 3 you must explain it > in the commit message, or maybe do another patch for that change. This one's a typo, I'll fix it in v3. Thanks, Easwar
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c index 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", }; -#define SECS * HZ -#define MINS * 60 SECS -#define HOURS * 60 MINS -#define DAYS * 24 HOURS - static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { - [SCTP_CONNTRACK_CLOSED] = 10 SECS, - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), }; #define SCTP_FLAG_HEARTBEAT_VTAG_FAILED 1
None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-)