diff mbox series

[net-next,2/5] eth: fbnic: add missing header guards

Message ID 20241115015344.757567-3-kuba@kernel.org (mailing list archive)
State Accepted
Commit 2a0d6c1705c42b81efd927f0bad91e68245dba7f
Delegated to: Netdev Maintainers
Headers show
Series eth: fbnic: cleanup and add a few stats | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 3 this patch: 3
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 3 maintainers not CCed: mohsin.bashr@gmail.com andrew+netdev@lunn.ch kernel-team@meta.com
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 4 this patch: 4
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-11-15--21-00 (tests: 789)

Commit Message

Jakub Kicinski Nov. 15, 2024, 1:53 a.m. UTC
While adding the SPDX headers I noticed we're also missing
a header guard.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andrew Lunn Nov. 17, 2024, 8:10 p.m. UTC | #1
On Thu, Nov 14, 2024 at 05:53:41PM -0800, Jakub Kicinski wrote:
> While adding the SPDX headers I noticed we're also missing
> a header guard.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Kalesh Anakkur Purayil Nov. 18, 2024, 3:55 a.m. UTC | #2
On Fri, Nov 15, 2024 at 7:24 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> While adding the SPDX headers I noticed we're also missing
> a header guard.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h b/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h
index a2b6e88fc113..199ad2228ee9 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h
@@ -1,6 +1,9 @@ 
 /* SPDX-License-Identifier: GPL-2.0 */
 /* Copyright (c) Meta Platforms, Inc. and affiliates. */
 
+#ifndef _FBNIC_HW_STATS_H_
+#define _FBNIC_HW_STATS_H_
+
 #include <linux/ethtool.h>
 
 #include "fbnic_csr.h"
@@ -41,3 +44,5 @@  struct fbnic_hw_stats {
 u64 fbnic_stat_rd64(struct fbnic_dev *fbd, u32 reg, u32 offset);
 
 void fbnic_get_hw_stats(struct fbnic_dev *fbd);
+
+#endif /* _FBNIC_HW_STATS_H_ */