| Message ID | 20241117083204.57738-1-intelfx@intelfx.name (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/5] net: usb: qmi_wwan: add IDs for EM7565 (9X50) in "MBIM USBIF" config | expand |
On 2024-11-17 15:31, Ivan Shapovalov wrote: > This change was discovered and tested using author's own EM7565 device. > > This "MBIM USBIF" configuration corresponds to the `AT!USBCOMP=1,1,xxx` > on-device USB composition setting. When activated, the VID:PID resets > to 1199:90b1 ("application" mode) + 1199:90b0 ("boot" mode, i.e. QDL). Hi Ivan, for the whole series 1-5, please include an lsusb -v or usb-devices listing for any device that you add support for. What you find in device firmware or in Qualcomm SDK drivers does not necessarily reflect what has actually been manufactured and consequently how those Id's could be used for a future different product. The 1199:90d3 is already supported by the option serial driver and that is where devices with interfaces supported by their unique interface attributes belong instead of being supported by interface number in qcserial. thanks Lars
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 0c011d8f5d4d..9a33393d4ce2 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1349,6 +1349,7 @@ static const struct usb_device_id products[] = { {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */ {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */ {QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */ + {QMI_QUIRK_SET_DTR(0x1199, 0x90b1, 8)}, /* Sierra Wireless EM7565 "MBIM USB-IF" */ {QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)}, /* Sierra Wireless EM7590 */ {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */ {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
This change was discovered and tested using author's own EM7565 device. This "MBIM USBIF" configuration corresponds to the `AT!USBCOMP=1,1,xxx` on-device USB composition setting. When activated, the VID:PID resets to 1199:90b1 ("application" mode) + 1199:90b0 ("boot" mode, i.e. QDL). The "MBIM USBIF" label comes from on-device help: ---8<--- AT!USBCOMP=? !USBCOMP: AT!USBCOMP=<Config Index>,<Config Type>,<Interface bitmask> <Config Index> - configuration index to which the composition applies, should be 1 <Config Type> - 1:MBIM USBIF, 2:PCIE USBIF, 3:Legacy-Generic, 4:RNDIS <Interface bitmask> - DIAG - 0x00000001, NMEA - 0x00000004, MODEM - 0x00000008, RMNET0 - 0x00000100, MBIM - 0x00001000, e.g. 10D - diag, nmea, modem, rmnet interfaces enabled 1009 - diag, modem, mbim interfaces enabled The default configuration is: at!usbcomp=1,3,10F OK ---8<--- Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name> --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+)