| Message ID | 20241118-simplify-result-qt2025-v1-1-f2d9cef17fca@iiitd.ac.in (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phy: qt2025: simplify Result<()> in probe return | expand |
On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote: > From: Manas <manas18244@iiitd.ac.in> > > probe returns a `Result<()>` type, which can be simplified as `Result`, > due to default type parameters being unit `()` and `Error` types. This > maintains a consistent usage of `Result` throughout codebase. > > Signed-off-by: Manas <manas18244@iiitd.ac.in> Miguel has already pointed out, this is probably not sufficient for a signed-off-by: You need a real name here, in order to keep the lawyers happy. Also, each subsystem has its own way of doing things. Please take a read of: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Andrew --- pw-bot: cr
On 18.11.2024 15:15, Andrew Lunn wrote: >On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote: >> From: Manas <manas18244@iiitd.ac.in> >> >> probe returns a `Result<()>` type, which can be simplified as `Result`, >> due to default type parameters being unit `()` and `Error` types. This >> maintains a consistent usage of `Result` throughout codebase. >> >> Signed-off-by: Manas <manas18244@iiitd.ac.in> > >Miguel has already pointed out, this is probably not sufficient for a >signed-off-by: You need a real name here, in order to keep the lawyers happy. > Hi Andrew, I did clarify that "Manas" is my real name, (as in what the official documents have). It is not a pseudonym. I am unsure if I am missing something here. >Also, each subsystem has its own way of doing things. Please take a >read of: > >https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html > > Andrew > >--- >pw-bot: cr I did take a look at the subsystem docs. I added target tree `net-next` and added all prefixes. I thought `Fixes:` tag wouldn't be appropriate here. I missed the Link: and Suggested by: tags as I was moving from v1. I will add those.
On 11/18/24 07:28, Manas wrote: > On 18.11.2024 15:15, Andrew Lunn wrote: >> On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote: >>> From: Manas <manas18244@iiitd.ac.in> >>> >>> probe returns a `Result<()>` type, which can be simplified as `Result`, >>> due to default type parameters being unit `()` and `Error` types. This >>> maintains a consistent usage of `Result` throughout codebase. >>> >>> Signed-off-by: Manas <manas18244@iiitd.ac.in> >> >> Miguel has already pointed out, this is probably not sufficient for a >> signed-off-by: You need a real name here, in order to keep the lawyers happy. >> > Hi Andrew, I did clarify that "Manas" is my real name, (as in what the official > documents have). It is not a pseudonym. I am unsure if I am missing something > here. > Using your full name in your Signed-off-by clearly identifies the author. I would recommend going that route. thanks, -- Shuah
diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..25c12a02baa255d3d5952e729a890b3ccfe78606 100644 --- a/drivers/net/phy/qt2025.rs +++ b/drivers/net/phy/qt2025.rs @@ -39,7 +39,7 @@ impl Driver for PhyQT2025 { const NAME: &'static CStr = c_str!("QT2025 10Gpbs SFP+"); const PHY_DEVICE_ID: phy::DeviceId = phy::DeviceId::new_with_exact_mask(0x0043a400); - fn probe(dev: &mut phy::Device) -> Result<()> { + fn probe(dev: &mut phy::Device) -> Result { // Check the hardware revision code. // Only 0x3b works with this driver and firmware. let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;