| Message ID | 20241121-feature_poe_port_prio-v3-25-83299fa6967c@bootlin.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for PSE port priority | expand |
On 21/11/2024 15:42, Kory Maincent wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > This patch adds the regulator supply parameter of the managers. > It updates also the example as the regulator supply of the PSE PIs > should be the managers itself and not an external regulator. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> ... unless you do not expect review. Best regards, Krzysztof
Hello Krzysztof, On Fri, 22 Nov 2024 07:58:26 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 21/11/2024 15:42, Kory Maincent wrote: > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > > > This patch adds the regulator supply parameter of the managers. > > It updates also the example as the regulator supply of the PSE PIs > > should be the managers itself and not an external regulator. > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > --- > > > > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> > > ... unless you do not expect review. Indeed I didn't expected binding reviews on this series that's why I did not add you and devicetree mailing list to the CC. I would like to confirm the core PSE design choices before that. Maybe I should have notify it somewhere to avoid you these emails, sorry. Regards,
On 22/11/2024 09:42, Kory Maincent wrote: >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. >> >> Please kindly resend and include all necessary To/Cc entries. >> </form letter> >> >> ... unless you do not expect review. > > Indeed I didn't expected binding reviews on this series that's why I did not add > you and devicetree mailing list to the CC. I would like to confirm the core PSE > design choices before that. > Maybe I should have notify it somewhere to avoid you these emails, sorry. No worries, I just never know whether this is intentional. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml index fd4244fceced..0dc0da32576b 100644 --- a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml +++ b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml @@ -68,6 +68,9 @@ properties: "#size-cells": const: 0 + vmain-supply: + description: Regulator power supply for the PD69208X manager. + patternProperties: '^port@[0-7]$': type: object @@ -106,10 +109,11 @@ examples: #address-cells = <1>; #size-cells = <0>; - manager@0 { + manager0: manager@0 { reg = <0>; #address-cells = <1>; #size-cells = <0>; + vmain-supply = <&pse1_supply>; phys0: port@0 { reg = <0>; @@ -128,7 +132,7 @@ examples: }; }; - manager@1 { + manager1: manager@1 { reg = <1>; #address-cells = <1>; #size-cells = <0>; @@ -161,7 +165,7 @@ examples: pairset-names = "alternative-a", "alternative-b"; pairsets = <&phys0>, <&phys1>; polarity-supported = "MDI", "S"; - vpwr-supply = <&vpwr1>; + vpwr-supply = <&manager0>; }; pse_pi1: pse-pi@1 { reg = <1>; @@ -169,7 +173,7 @@ examples: pairset-names = "alternative-a"; pairsets = <&phys2>; polarity-supported = "MDI"; - vpwr-supply = <&vpwr2>; + vpwr-supply = <&manager0>; }; }; };