| Message ID | 20241203072154.2440034-18-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | lan78xx: Preparations for PHYlink | expand |
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 2966f7e63617..c66e404f51ac 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -844,9 +844,7 @@ static int lan78xx_stop_hw(struct lan78xx_net *dev, u32 reg, u32 hw_enabled, } while (!stopped && !time_after(jiffies, timeout)); } - ret = stopped ? 0 : -ETIME; - - return ret; + return stopped ? 0 : -ETIMEDOUT; } static int lan78xx_flush_fifo(struct lan78xx_net *dev, u32 reg, u32 fifo_flush)
Update `lan78xx_stop_hw` to return `-ETIMEDOUT` instead of `-ETIME` when a timeout occurs. While `-ETIME` indicates a general timer expiration, `-ETIMEDOUT` is more commonly used for signaling operation timeouts and provides better consistency with standard error handling in the driver. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/usb/lan78xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)