| Message ID | 20241203085248.14575-4-divya.koppera@microchip.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add ptp library for Microchip phys | expand |
On Tue, Dec 03, 2024 at 02:22:46PM +0530, Divya Koppera wrote: > Add ptp library support in Kconfig > As some of Microchip T1 phys support ptp, add dependency > of 1588 optional flag in Kconfig > > Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev> > Signed-off-by: Divya Koppera <divya.koppera@microchip.com> > --- > v4 -> v5 > Addressed below review comments. > - Indentation fix > - Changed dependency check to if check for PTP_1588_CLOCK_OPTIONAL > > v1 -> v2 -> v3 -> v4 > - No changes > --- > drivers/net/phy/Kconfig | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 15828f4710a9..e97d389bb250 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -287,8 +287,15 @@ config MICROCHIP_PHY > > config MICROCHIP_T1_PHY > tristate "Microchip T1 PHYs" > + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING && \ > + PTP_1588_CLOCK_OPTIONAL > help > - Supports the LAN87XX PHYs. > + Supports the LAN8XXX PHYs. > + > +config MICROCHIP_PHYPTP > + tristate "Microchip PHY PTP" > + help > + Currently supports LAN887X T1 PHY How many different PTP implementations does Microchip have? I see mscc_ptp.c, lan743x_ptp.c, lan966x_ptp.c and sparx5_ptp.c. Plus this one. Does Microchip keep reinventing the wheel? Or can this library be used in place of any of these? And how many more ptp implementations will microchip have in the future? Maybe MICROCHIP_PHYPTP is too generic, maybe you should leave space for the next PTP implementation? Andrew
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 15828f4710a9..e97d389bb250 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -287,8 +287,15 @@ config MICROCHIP_PHY config MICROCHIP_T1_PHY tristate "Microchip T1 PHYs" + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING && \ + PTP_1588_CLOCK_OPTIONAL help - Supports the LAN87XX PHYs. + Supports the LAN8XXX PHYs. + +config MICROCHIP_PHYPTP + tristate "Microchip PHY PTP" + help + Currently supports LAN887X T1 PHY config MICROSEMI_PHY tristate "Microsemi PHYs"