| Message ID | 20241205113435.10601-1-gakula@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | af47a328e8130c81984cbcd1f771fc4bb777bd0f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] octeontx2-af: Fix installation of PF multicast rule | expand |
On Thu, Dec 05, 2024 at 05:04:35PM +0530, Geetha sowjanya wrote: > Due to target variable is being reassigned in npc_install_flow() > function, PF multicast rules are not getting installed. > This patch addresses the issue by fixing the "IF" condition > checks when rules are installed by AF. > > Fixes: 6c40ca957fe5 ("octeontx2-pf: Adds TC offload support"). > Signed-off-by: Geetha sowjanya <gakula@marvell.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 5 Dec 2024 17:04:35 +0530 you wrote: > Due to target variable is being reassigned in npc_install_flow() > function, PF multicast rules are not getting installed. > This patch addresses the issue by fixing the "IF" condition > checks when rules are installed by AF. > > Fixes: 6c40ca957fe5 ("octeontx2-pf: Adds TC offload support"). > Signed-off-by: Geetha sowjanya <gakula@marvell.com> > > [...] Here is the summary with links: - [net,v2] octeontx2-af: Fix installation of PF multicast rule https://git.kernel.org/netdev/net/c/af47a328e813 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c index da69e454662a..1b765045aa63 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c @@ -1452,23 +1452,21 @@ int rvu_mbox_handler_npc_install_flow(struct rvu *rvu, * hence modify pcifunc accordingly. */ - /* AF installing for a PF/VF */ - if (!req->hdr.pcifunc) + if (!req->hdr.pcifunc) { + /* AF installing for a PF/VF */ target = req->vf; - - /* PF installing for its VF */ - if (!from_vf && req->vf && !from_rep_dev) { + } else if (!from_vf && req->vf && !from_rep_dev) { + /* PF installing for its VF */ target = (req->hdr.pcifunc & ~RVU_PFVF_FUNC_MASK) | req->vf; pf_set_vfs_mac = req->default_rule && (req->features & BIT_ULL(NPC_DMAC)); - } - - /* Representor device installing for a representee */ - if (from_rep_dev && req->vf) + } else if (from_rep_dev && req->vf) { + /* Representor device installing for a representee */ target = req->vf; - else + } else { /* msg received from PF/VF */ target = req->hdr.pcifunc; + } /* ignore chan_mask in case pf func is not AF, revisit later */ if (!is_pffunc_af(req->hdr.pcifunc))
Due to target variable is being reassigned in npc_install_flow() function, PF multicast rules are not getting installed. This patch addresses the issue by fixing the "IF" condition checks when rules are installed by AF. Fixes: 6c40ca957fe5 ("octeontx2-pf: Adds TC offload support"). Signed-off-by: Geetha sowjanya <gakula@marvell.com> --- v1-v2: -Restructured the code. .../ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)