From patchwork Tue Dec 10 20:27:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacob Keller X-Patchwork-Id: 13902009 X-Patchwork-Delegate: kuba@kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B5F8227598 for ; Tue, 10 Dec 2024 20:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733862454; cv=none; b=txOh1TkRQUSYr2CuRmxi/bL8HL+9Zc1M9a0Rdx3Grk9oT8T7AsEEYjkSxGvpSg/WGe/wnkeyFyIC9ocaVUQ/gfUMoc6qeKGrj62fdALhu7cKgjFrmzos+muoVZNhPqkHvnKAEdZyuMrTkbD7w19wY68d6dhZc3xgkdep9hIgXeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733862454; c=relaxed/simple; bh=QhBy5skCDdYCaruWQquGER4sknWYPjC4RexIISpIkr0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KSJM5zjOCrHijEawcgUwt8p2oJLh8BFw3BsBGBFsH3pkdPZjpO3UUufgV/pqLG5i4Ml0SMuiwvmvqDwRwL8k+K8vbKF/mZvmuY84R0oJUxquQ4A+WxQBuppj5cBRtxyCG0uyH/NpTD8NI1r8TCywoNoNMzc2x+Aix6p5u7tjzlg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CI1IsDTe; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CI1IsDTe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733862452; x=1765398452; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=QhBy5skCDdYCaruWQquGER4sknWYPjC4RexIISpIkr0=; b=CI1IsDTehCywqwk3ajw+gYrW9bNrBUBT5+FJDCSOspPPRJ9SzvEivE9b QpQuZ3H6fFtRagvZBAFHjHlilxgttJy4vDCaXoJUVbrHo2e6kKNqCSvfK 6/EN8F06MeA/EorfSALMnEoyWChpS6za0QVI3UPBDLI42LANwdsdksqtG ZkMJwjNRceBxrVhudNbgKBgJTONECzFDFmo/7Sj5gc9k+Ar/xuIJg6YAc SWWm3WzOFYQIVPAzzrx9c7C4L/sOf1fJTyMgZMnjpwO4zmH5knKp0ixrL onckzYAUa03WyMAJsLYqZ+0qvJWf99B0EjLoo3y8wIT608LZekm1uuX5L A==; X-CSE-ConnectionGUID: kafGJfaVSbqztwNuHoc6lQ== X-CSE-MsgGUID: Lb2912SZQmeI4nY7iDcyIw== X-IronPort-AV: E=McAfee;i="6700,10204,11282"; a="34147301" X-IronPort-AV: E=Sophos;i="6.12,223,1728975600"; d="scan'208";a="34147301" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2024 12:27:28 -0800 X-CSE-ConnectionGUID: 3JHTOQOmTJOX+foqwpvibg== X-CSE-MsgGUID: akTX6UxFSYKgU0sdVw6IDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,223,1728975600"; d="scan'208";a="126424092" Received: from jekeller-desk.jf.intel.com ([10.166.241.20]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2024 12:27:28 -0800 From: Jacob Keller Date: Tue, 10 Dec 2024 12:27:14 -0800 Subject: [PATCH net-next v10 05/10] ice: remove int_q_state from ice_tlan_ctx Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241210-packing-pack-fields-and-ice-implementation-v10-5-ee56a47479ac@intel.com> References: <20241210-packing-pack-fields-and-ice-implementation-v10-0-ee56a47479ac@intel.com> In-Reply-To: <20241210-packing-pack-fields-and-ice-implementation-v10-0-ee56a47479ac@intel.com> To: Vladimir Oltean , Andrew Morton , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Masahiro Yamada , netdev Cc: Jacob Keller X-Mailer: b4 0.14.2 X-Patchwork-Delegate: kuba@kernel.org The int_q_state field of the ice_tlan_ctx structure represents the internal queue state. However, we never actually need to assign this or read this during normal operation. In fact, trying to unpack it would not be possible as it is larger than a u64. Remove this field from the ice_tlan_ctx structure, and remove its packing field from the ice_tlan_ctx_info array. Signed-off-by: Jacob Keller Reviewed-by: Przemek Kitszel --- drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 1 - drivers/net/ethernet/intel/ice/ice_common.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h index 611577ebc29d8250c8cce85f58f3477ff3b51a66..0e8ed8c226e68988664d64c1fd3297cee32af020 100644 --- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h +++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h @@ -590,7 +590,6 @@ struct ice_tlan_ctx { u8 drop_ena; u8 cache_prof_idx; u8 pkt_shaper_prof_idx; - u8 int_q_state; /* width not needed - internal - DO NOT WRITE!!! */ }; #endif /* _ICE_LAN_TX_RX_H_ */ diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index 496d86cbd13fc3439e69c62eed8d730906e4d45b..e2a4f4897119f68a4036b69caca0a03dbc6636ce 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -1470,7 +1470,6 @@ const struct ice_ctx_ele ice_tlan_ctx_info[] = { ICE_CTX_STORE(ice_tlan_ctx, drop_ena, 1, 165), ICE_CTX_STORE(ice_tlan_ctx, cache_prof_idx, 2, 166), ICE_CTX_STORE(ice_tlan_ctx, pkt_shaper_prof_idx, 3, 168), - ICE_CTX_STORE(ice_tlan_ctx, int_q_state, 122, 171), { 0 } };