@@ -85,7 +85,6 @@ static void ice_gnss_read(struct kthread_work *work)
{
struct gnss_serial *gnss = container_of(work, struct gnss_serial,
read_work.work);
- unsigned long delay = ICE_GNSS_POLL_DATA_DELAY_TIME;
unsigned int i, bytes_read, data_len, count;
struct ice_aqc_link_topo_addr link_topo;
char buf[ICE_MAX_I2C_DATA_SIZE];
@@ -140,9 +139,9 @@ static void ice_gnss_read(struct kthread_work *work)
count, bytes_read);
}
- delay = ICE_GNSS_TIMER_DELAY_TIME;
requeue:
- kthread_queue_delayed_work(gnss->kworker, &gnss->read_work, delay);
+ kthread_queue_delayed_work(gnss->kworker, &gnss->read_work,
+ ICE_GNSS_POLL_DATA_DELAY_TIME);
if (err)
dev_dbg(ice_pf_to_dev(pf), "GNSS failed to read err=%d\n", err);
}
@@ -6,7 +6,6 @@
#define ICE_E810T_GNSS_I2C_BUS 0x2
#define ICE_GNSS_POLL_DATA_DELAY_TIME (HZ / 50) /* poll every 20 ms */
-#define ICE_GNSS_TIMER_DELAY_TIME (HZ / 10) /* 0.1 second per message */
#define ICE_GNSS_TTY_WRITE_BUF 250
/* ICE_MAX_I2C_DATA_SIZE is FIELD_MAX(ICE_AQC_I2C_DATA_SIZE_M).
* However, FIELD_MAX() does not evaluate to an integer constant expression,
I do not see a reason to have a special longer delay (100 ms) after passing read GNSS data to userspace. Just use the regular GNSS polling interval (20 ms). Signed-off-by: Michal Schmidt <mschmidt@redhat.com> --- drivers/net/ethernet/intel/ice/ice_gnss.c | 5 ++--- drivers/net/ethernet/intel/ice/ice_gnss.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-)