From patchwork Wed Dec 18 13:09:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Liang X-Patchwork-Id: 13913655 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A8771FCFC2; Wed, 18 Dec 2024 13:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734527457; cv=none; b=Kg5X+Asqsh/CeptfwkVuJxe1OLuZUK9e9rDRUEWrDO88dNVsTUIyWUlDjs7Su3iObEHE10J1LjwA4gQ6Wlz/ram+wDcB064iWa0h6S73tqvJZlgPhyxQ7wK48G5FlX4/qFznhslZudcHPuu/mIdK4XOSAVTI6o6tl1o1sqlTK2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734527457; c=relaxed/simple; bh=MmoB5+7EOmwBm0nVVOoQDyuB6FG4U5u804h3NW5wIi8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jGQJU5vPH+o2UpEFvcP95GWKyMXI23dywS+AoOKLCwhRbyLfSVevQpeNcL3xX1hUBQEyd+s+2i0nMOWF2JQaVbuHxFI8T7jFmxgw2ADGZ9vEuo4UM+4BegR3Jemuho550E79nPIL8n0tX8CifgXgX+DOwEnPiS/0r0DbePoKGgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B67qp6RZ; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B67qp6RZ" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2166651f752so68023295ad.3; Wed, 18 Dec 2024 05:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734527454; x=1735132254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cEe2srsfNQuo3cFtk4Exr0i8mchzSjDC/1TEtzbMZ8U=; b=B67qp6RZKhQnvemU+DKJ1ktWXZyOdMzlOUqwo+QdAnhWwxIbRRECHjtiyCieQlie1M ShXJ6QzBrCtLNjzOwHlLheFKjP5qOT+Rx0/aMc42SatHLVV+Q/h2UGHVFtCHYqHGSVKc wWZ2/3lz1vJ5jLnKe37l5B8Xr8wKa9FgRXT2hOAYMpfdki0EifFNy+LwmtzYxNaH9hkR 5H/IZ8wK+ySzuIETBb/FA167p9uls/EasNPlIg/IkTXrqY/k+WZxrkDzbxXnB0aZLhiW JhTfIv44cxi2wX6IaDqTRJRc7hqa0cfMRp2LQ2oPheJacMrDaSaWOb8TvNwFtldka3zv 8J1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734527454; x=1735132254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cEe2srsfNQuo3cFtk4Exr0i8mchzSjDC/1TEtzbMZ8U=; b=P0ry8xqrRBtX9Hkw91oTG1LaO1556Az8EfRNMtaQJvG/IySN1JfHj2TBUDdEg2sdfS ivjceOyi6dwRSN7pswoazQ7GZpIaRJkz1i4830puKCixlkchrpdegW5dwx7bapeEhPBC EcGVfvZ+e6YWbH7cRxZEbGuLGx8EOFDAFDvTXIRgBFvYM+O4OP5HzisvWQKwkz8bFOaT DbfVBrcHVbaV0TdGIgTM3ZMG8veQL/bUfvdjs8HUu8tlOAV8cd1i8cXqcdQELSJVe8RK VdrWccETtVyr+ESgImlFEbsIfeXtZ9mwr1L6lQHmEMhTWAiVXTP521epRsPKOPvh52ls 74bA== X-Forwarded-Encrypted: i=1; AJvYcCU6VCx46l+HPxRjkcW/eY9nODZJfX6oTTxPhdJ7G9g/ccjG0bJTEaHG5FPmS0uO4eEWZrWZ2ih3obXoCQ==@vger.kernel.org, AJvYcCUFfnK+jkJ9NIrXYlCmfmsgoOEOJ7rW1+mlbFSf8BD5gBO+KJc5L/WhKeHr4dYoEZohHKMBy/37IitV7LKFfiU=@vger.kernel.org, AJvYcCUSu97E2Je16rP74s4aLc83+TWqmhsS9hgSkDUAAO6VcEAswUCBM8v1HQ0EwfeQ4n8sMFVPVG8L4qJl@vger.kernel.org, AJvYcCUhCqtIjqro8hkwPtPmgsOoH8UNalKTToqjU5xOpv8qVuDrBkXeP9liH716c67jYOjfwOpoG/r0ARYm@vger.kernel.org, AJvYcCWRjkc64wGLdK+fvVkf/iqEaZaksPBzuPOADFdEWlimqNJbC4Z4KpT+owzRtwrdBwhGewwX2hIVtQSoF9R4@vger.kernel.org, AJvYcCWXHow90aZJ0YUdmrvqY1VLXkY5U13a011VTYqypeaDg5HyfOxtdGgIiLG57lBYSIYDi3dNzpfQdugxqocDSFhx@vger.kernel.org, AJvYcCXLQFOuB6ytpGz2qRBQbTo/G0Le9oNTy2V4rnbHkq8BPOuXeb3nM++kkt/G0uvl+QzRwGI9vWK5iHcnYg==@vger.kernel.org, AJvYcCXqIouqt+x1KtfysuulEdDt31ZY1ZEWE3aFYP8Ijb/l6oNzbOJ2xxnsHgNJlW6ivuZfMlk=@vger.kernel.org X-Gm-Message-State: AOJu0YxZWAna5M1IJvQ0A7c6tOCigB6Qieym3J9sKWRP6JTvGnY2xK9L 66+QzuCNxJwUl7NbIZom46ZC/CGMAhK3YMFN6tt6s22aTD/GTk5VnxnUX/afFxk= X-Gm-Gg: ASbGnctbqw0lI4keK6Bv16I8TF6yIYG6I6JwjcX+kI9qbX1Ipl+iIH3C6308wQfOqbh QDhNFoqJ2AcBENx3bdJM3i/Y+wggGuyDi2fYSDI8J3ks0tzWSslskNlbChMUJyFKjxVaZexvI16 qE4QdiO8Zfbr6KK6wUAc7PNz+l1JUpauVrByxEqDaXUwgGRN6+i3JLz5fgUDvLfwTCwp0h3aNu0 9ce7tUGk5Mpwi4u2KuDrnwKzS4YHKidcGAKO9/FFJr/EJs= X-Google-Smtp-Source: AGHT+IGW2ivQBr6ib7m/cmjzjnkogelPQGpBxwq3iWWAr6K+/MU6YNZqq3IUhKj+TIVnGpc4fMVSow== X-Received: by 2002:a17:902:f985:b0:216:6c77:7bbb with SMTP id d9443c01a7336-218d70dc242mr29804885ad.17.1734527454469; Wed, 18 Dec 2024 05:10:54 -0800 (PST) Received: from ws.. ([103.167.140.11]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5c0f59asm7434754a12.67.2024.12.18.05.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 05:10:53 -0800 (PST) From: Xiao Liang To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Kuniyuki Iwashima , Jakub Kicinski , Donald Hunter , Paolo Abeni Cc: "David S. Miller" , David Ahern , Eric Dumazet , Ido Schimmel , Andrew Lunn , Simon Horman , Shuah Khan , Jiri Pirko , Hangbin Liu , linux-rdma@vger.kernel.org, linux-can@vger.kernel.org, osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org, linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com, linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, bridge@lists.linux.dev, linux-wpan@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v6 11/11] selftests: net: Add test cases for link and peer netns Date: Wed, 18 Dec 2024 21:09:09 +0800 Message-ID: <20241218130909.2173-12-shaw.leon@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241218130909.2173-1-shaw.leon@gmail.com> References: <20241218130909.2173-1-shaw.leon@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org - Add test for creating link in another netns when a link of the same name and ifindex exists in current netns. - Add test to verify that link is created in target netns directly - no link new/del events should be generated in link netns or current netns. - Add test cases to verify that link-netns is set as expected for various drivers and combination of namespace-related parameters. Signed-off-by: Xiao Liang --- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/link_netns.py | 142 ++++++++++++++++++++++ tools/testing/selftests/net/netns-name.sh | 10 ++ 3 files changed, 153 insertions(+) create mode 100755 tools/testing/selftests/net/link_netns.py diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index f09bd96cc978..cc6665212304 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -35,6 +35,7 @@ TEST_PROGS += cmsg_so_mark.sh TEST_PROGS += cmsg_so_priority.sh TEST_PROGS += cmsg_time.sh cmsg_ipv6.sh TEST_PROGS += netns-name.sh +TEST_PROGS += link_netns.py TEST_PROGS += nl_netdev.py TEST_PROGS += srv6_end_dt46_l3vpn_test.sh TEST_PROGS += srv6_end_dt4_l3vpn_test.sh diff --git a/tools/testing/selftests/net/link_netns.py b/tools/testing/selftests/net/link_netns.py new file mode 100755 index 000000000000..c4b2ddf201ff --- /dev/null +++ b/tools/testing/selftests/net/link_netns.py @@ -0,0 +1,142 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 + +import time + +from lib.py import ksft_run, ksft_exit, ksft_true +from lib.py import ip +from lib.py import NetNS, NetNSEnter +from lib.py import RtnlFamily + + +LINK_NETNSID = 100 + + +def test_event() -> None: + with NetNS() as ns1, NetNS() as ns2: + with NetNSEnter(str(ns2)): + rtnl = RtnlFamily() + + rtnl.ntf_subscribe("rtnlgrp-link") + + ip(f"netns set {ns2} {LINK_NETNSID}", ns=str(ns1)) + ip(f"link add netns {ns1} link-netnsid {LINK_NETNSID} dummy1 type dummy") + ip(f"link add netns {ns1} dummy2 type dummy", ns=str(ns2)) + + ip("link del dummy1", ns=str(ns1)) + ip("link del dummy2", ns=str(ns1)) + + time.sleep(1) + rtnl.check_ntf() + ksft_true(rtnl.async_msg_queue.empty(), + "Received unexpected link notification") + + +def validate_link_netns(netns, ifname, link_netnsid) -> bool: + link_info = ip(f"-d link show dev {ifname}", ns=netns, json=True) + if not link_info: + return False + return link_info[0].get("link_netnsid") == link_netnsid + + +def test_link_net() -> None: + configs = [ + # type, common args, type args, fallback to dev_net + ("ipvlan", "link dummy1", "", False), + ("macsec", "link dummy1", "", False), + ("macvlan", "link dummy1", "", False), + ("macvtap", "link dummy1", "", False), + ("vlan", "link dummy1", "id 100", False), + ("gre", "", "local 192.0.2.1", True), + ("vti", "", "local 192.0.2.1", True), + ("ipip", "", "local 192.0.2.1", True), + ("ip6gre", "", "local 2001:db8::1", True), + ("ip6gre", "", "local 2001:db8::1", True), + ("ip6tnl", "", "local 2001:db8::1", True), + ("vti6", "", "local 2001:db8::1", True), + ("sit", "", "local 192.0.2.1", True), + ("xfrm", "", "if_id 1", True), + ] + + with NetNS() as ns1, NetNS() as ns2, NetNS() as ns3: + net1, net2, net3 = str(ns1), str(ns2), str(ns3) + + # prepare link netnsid and a dummy link needed by certain drivers + ip(f"netns set {net3} {LINK_NETNSID}", ns=str(net2)) + ip("link add dummy1 type dummy", ns=net3) + + cases = [ + # source, "netns", "link-netns", expected link-netns + (net3, None, None, None, None), + (net3, net2, None, None, LINK_NETNSID), + (net2, None, net3, LINK_NETNSID, LINK_NETNSID), + (net1, net2, net3, LINK_NETNSID, LINK_NETNSID), + ] + + for src_net, netns, link_netns, exp1, exp2 in cases: + tgt_net = netns or src_net + for typ, cargs, targs, fb_dev_net in configs: + cmd = "link add" + if netns: + cmd += f" netns {netns}" + if link_netns: + cmd += f" link-netns {link_netns}" + cmd += f" {cargs} foo type {typ} {targs}" + ip(cmd, ns=src_net) + if fb_dev_net: + ksft_true(validate_link_netns(tgt_net, "foo", exp1), + f"{typ} link_netns validation failed") + else: + ksft_true(validate_link_netns(tgt_net, "foo", exp2), + f"{typ} link_netns validation failed") + ip(f"link del foo", ns=tgt_net) + + +def test_peer_net() -> None: + types = [ + "vxcan", + "netkit", + "veth", + ] + + with NetNS() as ns1, NetNS() as ns2, NetNS() as ns3, NetNS() as ns4: + net1, net2, net3, net4 = str(ns1), str(ns2), str(ns3), str(ns4) + + ip(f"netns set {net3} {LINK_NETNSID}", ns=str(net2)) + + cases = [ + # source, "netns", "link-netns", "peer netns", expected + (net1, None, None, None, None), + (net1, net2, None, None, None), + (net2, None, net3, None, LINK_NETNSID), + (net1, net2, net3, None, None), + (net2, None, None, net3, LINK_NETNSID), + (net1, net2, None, net3, LINK_NETNSID), + (net2, None, net2, net3, LINK_NETNSID), + (net1, net2, net4, net3, LINK_NETNSID), + ] + + for src_net, netns, link_netns, peer_netns, exp in cases: + tgt_net = netns or src_net + for typ in types: + cmd = "link add" + if netns: + cmd += f" netns {netns}" + if link_netns: + cmd += f" link-netns {link_netns}" + cmd += f" foo type {typ}" + if peer_netns: + cmd += f" peer netns {peer_netns}" + ip(cmd, ns=src_net) + ksft_true(validate_link_netns(tgt_net, "foo", exp), + f"{typ} peer_netns validation failed") + ip(f"link del foo", ns=tgt_net) + + +def main() -> None: + ksft_run([test_event, test_link_net, test_peer_net]) + ksft_exit() + + +if __name__ == "__main__": + main() diff --git a/tools/testing/selftests/net/netns-name.sh b/tools/testing/selftests/net/netns-name.sh index 6974474c26f3..0be1905d1f2f 100755 --- a/tools/testing/selftests/net/netns-name.sh +++ b/tools/testing/selftests/net/netns-name.sh @@ -78,6 +78,16 @@ ip -netns $NS link show dev $ALT_NAME 2> /dev/null && fail "Can still find alt-name after move" ip -netns $test_ns link del $DEV || fail +# +# Test no conflict of the same name/ifindex in different netns +# +ip -netns $NS link add name $DEV index 100 type dummy || fail +ip -netns $NS link add netns $test_ns name $DEV index 100 type dummy || + fail "Can create in netns without moving" +ip -netns $test_ns link show dev $DEV >> /dev/null || fail "Device not found" +ip -netns $NS link del $DEV || fail +ip -netns $test_ns link del $DEV || fail + echo -ne "$(basename $0) \t\t\t\t" if [ $RET_CODE -eq 0 ]; then echo "[ OK ]"