| Message ID | 20250109121432.12664-1-divya.koppera@microchip.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: phy: Kconfig: Fix error related to undefined reference | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/apply | fail | Patch does not apply to net-0 |
On Thu, Jan 09, 2025 at 05:44:32PM +0530, Divya Koppera wrote: > When microchip_t1_phy is built in and phyptp is module > facing undefined reference issue. This get fixed when > microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: > https://lore.kernel.org/oe-kbuild-all/202501090604.YEoJXCXi-lkp@intel.com > Fixes: fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys") > Signed-off-by: Divya Koppera <divya.koppera@microchip.com> Hi Divya, I think that this patch should be targeted at net-next, where the problem seems to manifest, rather than net where it does not. Likewise, this patch applies to net-next, but not net. Also, I think the prefix for the patch should be "net: phy: microchip_t1". And perhaps the following subject is a bit more descriptive. [PATCH net-next] net: phy: microchip_t1: depend on PTP_1588_CLOCK_OPTIONAL As for the code change itself, it looks good to me. Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index dc625f2b3ae4..9ad3dbfd2f99 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -287,8 +287,8 @@ config MICROCHIP_PHY config MICROCHIP_T1_PHY tristate "Microchip T1 PHYs" - select MICROCHIP_PHY_RDS_PTP if NETWORK_PHY_TIMESTAMPING && \ - PTP_1588_CLOCK_OPTIONAL + select MICROCHIP_PHY_RDS_PTP if NETWORK_PHY_TIMESTAMPING + depends on PTP_1588_CLOCK_OPTIONAL help Supports the LAN8XXX PHYs.
When microchip_t1_phy is built in and phyptp is module facing undefined reference issue. This get fixed when microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501090604.YEoJXCXi-lkp@intel.com Fixes: fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys") Signed-off-by: Divya Koppera <divya.koppera@microchip.com> --- drivers/net/phy/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)