From patchwork Fri Jan 10 12:27:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13934409 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE5EB20DD68; Fri, 10 Jan 2025 12:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736512074; cv=none; b=P7fO0e3t9IRSXWHEx3MuyDQIlIAVQTImBuFXttor1YnToe6qLrtJ9f2SbfvO7Uk88V5qAYe3MBudsbg1WVRuqK7fKY7xIS90MQCLI/1C4lzGiosq18c+H0l3QfrU/Aq13IPnwrqiiLDC7POz0iboPM+Jg+DputDTPIUuN1kZOcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736512074; c=relaxed/simple; bh=AGoNi2q12R7UWcvKJW5nIcT941Z9KEhYeQn8JcqgGks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lt5QKcDAbpbnM5gGeVJPnFK59/lkmtG6xt5QMMmdpy9RaT5FTQR01W5Wqkq55hKRhsHTSTpVhpyMQXJLzeGrWoN6dApXx+lAMW3i4Qa/GOMTK9/8xr1T+RWpKn7BOAc7URywsAR3Bh5Hiyo/pDZ2OixVATj2ouYb9fC5KoZF3ww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=PecW+2R0; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="PecW+2R0" Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50A9Lsdu002563; Fri, 10 Jan 2025 04:27:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=A uW5U8Pc/en9sdx+ihLAF+LAzEo4rZP7ZGaVf0clh+A=; b=PecW+2R0XEZbRODTj PJybj6eEFMMAa/sQ6MQ2TsyuAzeGVUT1iw/mRs/ddAISACwhZhkbKGtHJVCeTxNM zUW98e44Yk05YXsePK27gfG5frqHUaANZ97Vxa+e4W4xqglqSR+J2Sw+Lpebz4HU VcdDhtko5y5R8mF3n0OA5S7vTa4qf2rpx8FMrx+NaJEz9KQFclHoJ33ergr1kbgq OJLSEGUOShhsyuqJVwlYCDe/3praQkJTF+OS6oXBPBdelsGAbRULO3EwJ1nVVrFD Izqa04386Kkb0kKx5n/f69ZIxJ7XfFiAJkmQWMHdhlegexwhra69FoiUHvkcFy0j rrJxw== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4430umr9rs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jan 2025 04:27:39 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 10 Jan 2025 04:27:38 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Fri, 10 Jan 2025 04:27:38 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id 807A63F705A; Fri, 10 Jan 2025 04:27:37 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Abhijit Ayarekar , Satananda Burla Subject: [PATCH net v6 2/4] octeon_ep: remove firmware stats fetch in ndo_get_stats64 Date: Fri, 10 Jan 2025 04:27:28 -0800 Message-ID: <20250110122730.2551863-3-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250110122730.2551863-1-srasheed@marvell.com> References: <20250110122730.2551863-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: 1PVp-ibECl8QVTLdQxhH9n3biEdtA47O X-Proofpoint-ORIG-GUID: 1PVp-ibECl8QVTLdQxhH9n3biEdtA47O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Patchwork-Delegate: kuba@kernel.org The per queue stats are available already and are retrieved from register reads during ndo_get_stats64. The firmware stats fetch call that happens in ndo_get_stats64() is currently not required The warn log is given below: [ 123.316837] ------------[ cut here ]------------ [ 123.316840] Voluntary context switch within RCU read-side critical section! [ 123.316917] pc : rcu_note_context_switch+0x2e4/0x300 [ 123.316919] lr : rcu_note_context_switch+0x2e4/0x300 [ 123.316947] Call trace: [ 123.316949] rcu_note_context_switch+0x2e4/0x300 [ 123.316952] __schedule+0x84/0x584 [ 123.316955] schedule+0x38/0x90 [ 123.316956] schedule_timeout+0xa0/0x1d4 [ 123.316959] octep_send_mbox_req+0x190/0x230 [octeon_ep] [ 123.316966] octep_ctrl_net_get_if_stats+0x78/0x100 [octeon_ep] [ 123.316970] octep_get_stats64+0xd4/0xf0 [octeon_ep] [ 123.316975] dev_get_stats+0x4c/0x114 [ 123.316977] dev_seq_printf_stats+0x3c/0x11c [ 123.316980] dev_seq_show+0x1c/0x40 [ 123.316982] seq_read_iter+0x3cc/0x4e0 [ 123.316985] seq_read+0xc8/0x110 [ 123.316987] proc_reg_read+0x9c/0xec [ 123.316990] vfs_read+0xc8/0x2ec [ 123.316993] ksys_read+0x70/0x100 [ 123.316995] __arm64_sys_read+0x20/0x30 [ 123.316997] invoke_syscall.constprop.0+0x7c/0xd0 [ 123.317000] do_el0_svc+0xb4/0xd0 [ 123.317002] el0_svc+0xe8/0x1f4 [ 123.317005] el0t_64_sync_handler+0x134/0x150 [ 123.317006] el0t_64_sync+0x17c/0x180 [ 123.317008] ---[ end trace 63399811432ab69b ]--- Fixes: 6a610a46bad1 ("octeon_ep: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V6: - Corrected patch to apply properly V5: https://lore.kernel.org/all/20250109103221.2544467-3-srasheed@marvell.com/ - No changes V4: https://lore.kernel.org/all/20250102112246.2494230-3-srasheed@marvell.com/ - No changes V3: https://lore.kernel.org/all/20241218115111.2407958-3-srasheed@marvell.com/ - Added warn log that happened due to rcu_read_lock in commit message V2: https://lore.kernel.org/all/20241216075842.2394606-3-srasheed@marvell.com/ - No changes V1: https://lore.kernel.org/all/20241203072130.2316913-3-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index c5fdedd3ea78..990fbd5df43a 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -1005,20 +1005,10 @@ static void octep_get_stats64(struct net_device *netdev, oct->iface_rx_stats.octets += oct->stats_oq[q].bytes; } - if (netif_running(netdev)) - octep_ctrl_net_get_if_stats(oct, - OCTEP_CTRL_NET_INVALID_VFID, - &oct->iface_rx_stats, - &oct->iface_tx_stats); - stats->tx_packets = oct->iface_tx_stats.pkts; stats->tx_bytes = oct->iface_tx_stats.octs; stats->rx_packets = oct->iface_rx_stats.pkts; stats->rx_bytes = oct->iface_rx_stats.octets; - stats->multicast = oct->iface_rx_stats.mcast_pkts; - stats->rx_errors = oct->iface_rx_stats.err_pkts; - stats->collisions = oct->iface_tx_stats.xscol; - stats->tx_fifo_errors = oct->iface_tx_stats.undflw; } /**