| Message ID | 20250117-vsock-transport-vs-autobind-v1-2-c802c803762d@rbox.co (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | vsock: Transport reassignment and error handling issues | expand |
On Fri, Jan 17, 2025 at 10:59:42PM +0100, Michal Luczaj wrote: >sk_err is set when a (connectible) connect() fails. Effectively, this makes >an otherwise still healthy SS_UNCONNECTED socket impossible to use for any >subsequent connection attempts. > >Clear sk_err upon trying to establish a connection. > >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Signed-off-by: Michal Luczaj <mhal@rbox.co> >--- > net/vmw_vsock/af_vsock.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index cfe18bc8fdbe7ced073c6b3644d635fdbfa02610..075695173648d3a4ecbd04e908130efdbb393b41 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1523,6 +1523,11 @@ static int vsock_connect(struct socket *sock, struct sockaddr *addr, > if (err < 0) > goto out; > >+ /* sk_err might have been set as a result of an earlier >+ * (failed) connect attempt. >+ */ >+ sk->sk_err = 0; >+ LGTM! Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > /* Mark sock as connecting and set the error code to in > * progress in case this is a non-blocking connect. > */ > >-- >2.47.1 >
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index cfe18bc8fdbe7ced073c6b3644d635fdbfa02610..075695173648d3a4ecbd04e908130efdbb393b41 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1523,6 +1523,11 @@ static int vsock_connect(struct socket *sock, struct sockaddr *addr, if (err < 0) goto out; + /* sk_err might have been set as a result of an earlier + * (failed) connect attempt. + */ + sk->sk_err = 0; + /* Mark sock as connecting and set the error code to in * progress in case this is a non-blocking connect. */
sk_err is set when a (connectible) connect() fails. Effectively, this makes an otherwise still healthy SS_UNCONNECTED socket impossible to use for any subsequent connection attempts. Clear sk_err upon trying to establish a connection. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Signed-off-by: Michal Luczaj <mhal@rbox.co> --- net/vmw_vsock/af_vsock.c | 5 +++++ 1 file changed, 5 insertions(+)