| Message ID | 20250201013040.725123-4-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de379dfd9ada2995699052f4a1ecebe5d8f8d70f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ethtool: rss: minor fixes for recent RSS changes | expand |
On Fri, Jan 31, 2025 at 05:30:39PM -0800, Jakub Kicinski wrote: > Commit under Fixes adds ntuple rules but never deletes them. > > Fixes: 29a4bc1fe961 ("selftest: extend test_rss_context_queue_reconfigure for action addition") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > tools/testing/selftests/drivers/net/hw/rss_ctx.py | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Joe Damato <jdamato@fastly.com>
diff --git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py index ca8a7edff3dd..27e24e20749f 100755 --- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py +++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py @@ -252,6 +252,7 @@ from lib.py import ethtool, ip, defer, GenerateTraffic, CmdExitFailure try: # this targets queue 4, which doesn't exist ntuple2 = ethtool_create(cfg, "-N", flow) + defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}") except CmdExitFailure: pass else: @@ -260,6 +261,7 @@ from lib.py import ethtool, ip, defer, GenerateTraffic, CmdExitFailure ethtool(f"-X {cfg.ifname} {ctx_ref} weight 1 0 1 0") # ntuple rule therefore targets queues 1 and 3 ntuple2 = ethtool_create(cfg, "-N", flow) + defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}") # should replace existing filter ksft_eq(ntuple, ntuple2) _send_traffic_check(cfg, port, ctx_ref, { 'target': (1, 3),
Commit under Fixes adds ntuple rules but never deletes them. Fixes: 29a4bc1fe961 ("selftest: extend test_rss_context_queue_reconfigure for action addition") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- tools/testing/selftests/drivers/net/hw/rss_ctx.py | 2 ++ 1 file changed, 2 insertions(+)