| Message ID | 20250205173352.446704-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0bdcfaf84a9428c49f971be9024505b9e3b43038 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] tools: ynl: add all headers to makefile deps | expand |
On Wed, 5 Feb 2025 at 17:33, Jakub Kicinski <kuba@kernel.org> wrote: > > The Makefile.deps lists uAPI headers to make the build work when > system headers are older than in-tree headers. The problem doesn't > occur for new headers, because system headers are not there at all. > But out-of-tree YNL clone on GH also uses this header to identify > header dependencies, and one day the system headers will exist, > and will get out of date. So let's add the headers we missed. > > I don't think this is a fix, but FWIW the commits which added > the missing headers are: > > commit 04e65df94b31 ("netlink: spec: add shaper YAML spec") > commit 49922401c219 ("ethtool: separate definitions that are gonna be generated") > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 5 Feb 2025 09:33:52 -0800 you wrote: > The Makefile.deps lists uAPI headers to make the build work when > system headers are older than in-tree headers. The problem doesn't > occur for new headers, because system headers are not there at all. > But out-of-tree YNL clone on GH also uses this header to identify > header dependencies, and one day the system headers will exist, > and will get out of date. So let's add the headers we missed. > > [...] Here is the summary with links: - [net-next] tools: ynl: add all headers to makefile deps https://git.kernel.org/netdev/net-next/c/0bdcfaf84a94 You are awesome, thank you!
diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps index 0712b5e82eb7..d027a07c1e2c 100644 --- a/tools/net/ynl/Makefile.deps +++ b/tools/net/ynl/Makefile.deps @@ -17,9 +17,11 @@ get_hdr_inc=-D$(1) -include $(UAPI_PATH)/linux/$(2) CFLAGS_devlink:=$(call get_hdr_inc,_LINUX_DEVLINK_H_,devlink.h) CFLAGS_dpll:=$(call get_hdr_inc,_LINUX_DPLL_H,dpll.h) CFLAGS_ethtool:=$(call get_hdr_inc,_LINUX_ETHTOOL_H,ethtool.h) \ - $(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h) + $(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h) \ + $(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_GENERATED_H,ethtool_netlink_generated.h) CFLAGS_handshake:=$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h) CFLAGS_mptcp_pm:=$(call get_hdr_inc,_LINUX_MPTCP_PM_H,mptcp_pm.h) +CFLAGS_net_shaper:=$(call get_hdr_inc,_LINUX_NET_SHAPER_H,net_shaper.h) CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h) CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h) CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
The Makefile.deps lists uAPI headers to make the build work when system headers are older than in-tree headers. The problem doesn't occur for new headers, because system headers are not there at all. But out-of-tree YNL clone on GH also uses this header to identify header dependencies, and one day the system headers will exist, and will get out of date. So let's add the headers we missed. I don't think this is a fix, but FWIW the commits which added the missing headers are: commit 04e65df94b31 ("netlink: spec: add shaper YAML spec") commit 49922401c219 ("ethtool: separate definitions that are gonna be generated") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: donald.hunter@gmail.com CC: danieller@nvidia.com CC: sdf@fomichev.me --- tools/net/ynl/Makefile.deps | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)