| Message ID | 20250218-qt2025-comment-fix-v1-1-743e87c0040c@posteo.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: qt2025: Fix hardware revision check comment | expand |
On Mon, 17 Feb 2025 23:53:50 +0000 Charalampos Mitrodimas <charmitro@posteo.net> wrote: > Correct the hardware revision check comment in the QT2025 driver. The > revision value was documented as 0x3b instead of the correct 0xb3, > which matches the actual comparison logic in the code. > > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> > --- > drivers/net/phy/qt2025.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 > --- a/drivers/net/phy/qt2025.rs > +++ b/drivers/net/phy/qt2025.rs > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { > > fn probe(dev: &mut phy::Device) -> Result<()> { > // Check the hardware revision code. > - // Only 0x3b works with this driver and firmware. > + // Only 0xb3 works with this driver and firmware. > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; > if (hw_rev >> 8) != 0xb3 { > return Err(code::ENODEV); Oops, Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> Given that this patch is expected to be merged via netdev, you might need to resend with a proper subject: https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst Thanks,
On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote: > On Mon, 17 Feb 2025 23:53:50 +0000 > Charalampos Mitrodimas <charmitro@posteo.net> wrote: > > > Correct the hardware revision check comment in the QT2025 driver. The > > revision value was documented as 0x3b instead of the correct 0xb3, > > which matches the actual comparison logic in the code. > > > > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> > > --- > > drivers/net/phy/qt2025.rs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs > > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 > > --- a/drivers/net/phy/qt2025.rs > > +++ b/drivers/net/phy/qt2025.rs > > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { > > > > fn probe(dev: &mut phy::Device) -> Result<()> { > > // Check the hardware revision code. > > - // Only 0x3b works with this driver and firmware. > > + // Only 0xb3 works with this driver and firmware. > > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; > > if (hw_rev >> 8) != 0xb3 { > > return Err(code::ENODEV); > > Oops, > > Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> > > Given that this patch is expected to be merged via netdev, you might > need to resend with a proper subject: > > https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst Please also include a Fixes: tag. Andrew
Andrew Lunn <andrew@lunn.ch> writes: > On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote: >> On Mon, 17 Feb 2025 23:53:50 +0000 >> Charalampos Mitrodimas <charmitro@posteo.net> wrote: >> >> > Correct the hardware revision check comment in the QT2025 driver. The >> > revision value was documented as 0x3b instead of the correct 0xb3, >> > which matches the actual comparison logic in the code. >> > >> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> >> > --- >> > drivers/net/phy/qt2025.rs | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs >> > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 >> > --- a/drivers/net/phy/qt2025.rs >> > +++ b/drivers/net/phy/qt2025.rs >> > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { >> > >> > fn probe(dev: &mut phy::Device) -> Result<()> { >> > // Check the hardware revision code. >> > - // Only 0x3b works with this driver and firmware. >> > + // Only 0xb3 works with this driver and firmware. >> > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; >> > if (hw_rev >> 8) != 0xb3 { >> > return Err(code::ENODEV); >> >> Oops, >> >> Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> >> >> Given that this patch is expected to be merged via netdev, you might >> need to resend with a proper subject: >> >> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst > > Please also include a Fixes: tag. > > Andrew Hi Andrew, Included it, as the documentation states. A v2 patch is up[1]. C. Mitrodimas [1]: https://lore.kernel.org/rust-for-linux/20250219-qt2025-comment-fix-v2-1-029f67696516@posteo.net
FUJITA Tomonori <fujita.tomonori@gmail.com> writes: > On Mon, 17 Feb 2025 23:53:50 +0000 > Charalampos Mitrodimas <charmitro@posteo.net> wrote: > >> Correct the hardware revision check comment in the QT2025 driver. The >> revision value was documented as 0x3b instead of the correct 0xb3, >> which matches the actual comparison logic in the code. >> >> Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> >> --- >> drivers/net/phy/qt2025.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs >> index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 >> --- a/drivers/net/phy/qt2025.rs >> +++ b/drivers/net/phy/qt2025.rs >> @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { >> >> fn probe(dev: &mut phy::Device) -> Result<()> { >> // Check the hardware revision code. >> - // Only 0x3b works with this driver and firmware. >> + // Only 0xb3 works with this driver and firmware. >> let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; >> if (hw_rev >> 8) != 0xb3 { >> return Err(code::ENODEV); > > Oops, > > Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> > > Given that this patch is expected to be merged via netdev, you might > need to resend with a proper subject: > > https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst Hi Fujita, Very helpful; didn't think to check the Networking subsystem workflow docs. Thanks, C. Mitrodimas > > Thanks,
diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 --- a/drivers/net/phy/qt2025.rs +++ b/drivers/net/phy/qt2025.rs @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { fn probe(dev: &mut phy::Device) -> Result<()> { // Check the hardware revision code. - // Only 0x3b works with this driver and firmware. + // Only 0xb3 works with this driver and firmware. let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; if (hw_rev >> 8) != 0xb3 { return Err(code::ENODEV);
Correct the hardware revision check comment in the QT2025 driver. The revision value was documented as 0x3b instead of the correct 0xb3, which matches the actual comparison logic in the code. Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> --- drivers/net/phy/qt2025.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: beeb78d46249cab8b2b8359a2ce8fa5376b5ad2d change-id: 20250218-qt2025-comment-fix-31a7f8fcbc64 Best regards,