| Message ID | 20250218013653.229234-4-kylehendrydev@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: bcm63xx: Enable internal GPHY on BCM63268 | expand |
On Mon, Feb 17, 2025 at 05:36:42PM -0800, Kyle Hendry wrote: > Add documentation for the brcm,gphy-ctrl phandle to the > register for controlling ghpy modes. > > Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com> > --- > .../devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml > index 9ef28c2a0afc..9630b87b0473 100644 > --- a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml > +++ b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml > @@ -24,6 +24,11 @@ properties: > reg: > maxItems: 1 > Looks like whitespace error > +properties: > + brcm,gphy-ctrl: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: A phandle to the gphy control register Missing items. Why is this array? Anyway, explain the purpose of this phandle - how it is used by the *device*. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml index 9ef28c2a0afc..9630b87b0473 100644 --- a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml +++ b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml @@ -24,6 +24,11 @@ properties: reg: maxItems: 1 +properties: + brcm,gphy-ctrl: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: A phandle to the gphy control register + required: - compatible - reg @@ -42,6 +47,8 @@ examples: #address-cells = <1>; #size-cells = <0>; reg = <0>; + + brcm,gphy-ctrl = <&gphy_ctrl>; }; mdio_ext: mdio@1 {
Add documentation for the brcm,gphy-ctrl phandle to the register for controlling ghpy modes. Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com> --- .../devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml | 7 +++++++ 1 file changed, 7 insertions(+)