| Message ID | 20250218013653.229234-6-kylehendrydev@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | net: phy: bcm63xx: Enable internal GPHY on BCM63268 | expand |
On Mon, Feb 17, 2025 at 05:36:44PM -0800, Kyle Hendry wrote: > Add documentation for BCM63268 gphy controller in the > bcm63268-gpio-sysctl register range. > > Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com> > --- > .../bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml > index 9c2a04829da5..99610a5f2912 100644 > --- a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml > +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml > @@ -50,6 +50,15 @@ patternProperties: > should follow the bindings specified in > Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.yaml. > > + "^gphy_ctrl@[0-9a-f]+$": Read DTS coding style. > + # Child node > + type: object > + $ref: /schemas/mfd/syscon.yaml No, not really... how is syscon a child of other syscon? Isn't the other device the syscon? This looks really fake hardware description, like recent bootlin claim that "one register in syscon is device". > + description: > + Control register for GPHY modes. This child node definition > + should follow the bindings specified in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > required: > - "#address-cells" > - compatible > @@ -191,4 +200,8 @@ examples: > pins = "dsl_gpio9"; > }; > }; > + gphy_ctrl: gphy_ctrl@54 { > + compatible = "brcm,bcm63268-gphy-ctrl", "syscon"; Messed indentation. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml index 9c2a04829da5..99610a5f2912 100644 --- a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml @@ -50,6 +50,15 @@ patternProperties: should follow the bindings specified in Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.yaml. + "^gphy_ctrl@[0-9a-f]+$": + # Child node + type: object + $ref: /schemas/mfd/syscon.yaml + description: + Control register for GPHY modes. This child node definition + should follow the bindings specified in + Documentation/devicetree/bindings/mfd/syscon.yaml + required: - "#address-cells" - compatible @@ -191,4 +200,8 @@ examples: pins = "dsl_gpio9"; }; }; + gphy_ctrl: gphy_ctrl@54 { + compatible = "brcm,bcm63268-gphy-ctrl", "syscon"; + reg = <0x54 0x4>; + }; };
Add documentation for BCM63268 gphy controller in the bcm63268-gpio-sysctl register range. Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com> --- .../bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)