diff mbox series

[net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT

Message ID 20250219130923.7216-1-ansuelsmth@gmail.com (mailing list archive)
State Accepted
Commit 992ee3ed6e9fdd0be83a7daa5ff738e3cf86047f
Delegated to: Netdev Maintainers
Headers show
Series [net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2025-02-20--12-00 (tests: 893)

Commit Message

Christian Marangi Feb. 19, 2025, 1:09 p.m. UTC 
From: George Moussalem <george.moussalem@outlook.com>

While setting the DAC value, the wrong boolean value is evaluated to set
the DSP bias current. So let's correct the conditional statement and use
the right boolean value read from the DTS set in the priv.

Cc: stable@vger.kernel.org
Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/net/phy/qcom/qca807x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Feb. 19, 2025, 1:59 p.m. UTC | #1 
On Wed, Feb 19, 2025 at 02:09:21PM +0100, Christian Marangi wrote:
> From: George Moussalem <george.moussalem@outlook.com>
> 
> While setting the DAC value, the wrong boolean value is evaluated to set
> the DSP bias current. So let's correct the conditional statement and use
> the right boolean value read from the DTS set in the priv.
> 
> Cc: stable@vger.kernel.org
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org Feb. 20, 2025, 9:30 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 19 Feb 2025 14:09:21 +0100 you wrote:
> From: George Moussalem <george.moussalem@outlook.com>
> 
> While setting the DAC value, the wrong boolean value is evaluated to set
> the DSP bias current. So let's correct the conditional statement and use
> the right boolean value read from the DTS set in the priv.
> 
> Cc: stable@vger.kernel.org
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT
    https://git.kernel.org/netdev/net/c/992ee3ed6e9f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/qcom/qca807x.c b/drivers/net/phy/qcom/qca807x.c
index 3279de857b47..2ad8c2586d64 100644
--- a/drivers/net/phy/qcom/qca807x.c
+++ b/drivers/net/phy/qcom/qca807x.c
@@ -774,7 +774,7 @@  static int qca807x_config_init(struct phy_device *phydev)
 	control_dac &= ~QCA807X_CONTROL_DAC_MASK;
 	if (!priv->dac_full_amplitude)
 		control_dac |= QCA807X_CONTROL_DAC_DSP_AMPLITUDE;
-	if (!priv->dac_full_amplitude)
+	if (!priv->dac_full_bias_current)
 		control_dac |= QCA807X_CONTROL_DAC_DSP_BIAS_CURRENT;
 	if (!priv->dac_disable_bias_current_tweak)
 		control_dac |= QCA807X_CONTROL_DAC_BIAS_CURRENT_TWEAK;