From patchwork Thu Feb 20 21:39:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13984517 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1BAF264F84; Thu, 20 Feb 2025 21:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740087682; cv=fail; b=fMzdQI2qExgYe0ZWn072ObckntLulVM9akViFFW9exMoBZejMxet4pp/lqiCm0TUvllI06IHTgsTTiGDC+21v6zBTccqAIECzZlweAYO+hu1Gw8J5PwydOghQkdPLRUifnOn9TwiP8XSvPGsCz2qqwZu6sljZXjPdWUpXJPDuYY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740087682; c=relaxed/simple; bh=QyKm1IsKsVCyshqiXw0T6lfCmWfp7Au++5VDUXpgYKU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z+vYiFXiEiT42MKUCMDlkFh7C9a411JqxF1hPZSsqBOMSRk+gwQbiwTl9MzTH953jle8YkUNx9wx+oe+5fW7t29Vlv0ey/EIEj+qmsXhNA1WLlJZyAfVS0o4C6iUqNki/HZpF2Ne7uVEiUhcjbc74EPKpfyRQ6np8akxt6Maa8o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AAJQBof4; arc=fail smtp.client-ip=40.107.244.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AAJQBof4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FF136L48qzCKsnIYkUWcjlC+nUti8rmXWMQKVRLeAaORGN/1eGJjmw1Fa0sZP4ylonI/QG4N+ZOKSq1TKgu12FsnBRgxkRF1ZE80x31bvgKQLLciksN4wXAM7O21mCtMwC3jv2i3W2NFTwKj9HO2ItsKXEW7imPahZX485Fkaza52ezg3HfWhnpCpklrrqllq+vcvodIFT/MDAb3QFatrDzH3JFCdFAEEVooeQVd8D6SOlfd10wMTkFHpvTWe0iv3ciCm1DuNXEbImx6hCLVTeBZDOeQpdOdmg82l/tHe6qFRTf9rHmLDREC+yWBnMvMFnYXp97luw9myumdpPSnPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WlB7CJkblbu71GHl37/tYt2PEL3oFAKlAjjQ7yk7se8=; b=JY1GgfH5WBz80xKDiHl+xy6pmlazuIwwIha4yw7kKrYjsbFaA/hj4RGriRutEd6GKRwVIBX6Bj3saco9ZryOhmOrW6MzpYK4W998GGy9r6v2HizQw0XdNxGmfEXhGIbBTAQtvGXUiwleFfjLbjClRpE45I5NYHKRAV1nIPsTaX64QF18Sr9QXArt15pcPYAc4BGOZziqioiGvfKGZft8qbVIunpC0c8N7pkJ7fuoyhuaFR1r9f8TaURtkrMM/37FGYUB5T5nbLgVRjtBQr/6MiQoO1Dsx2UdO2NuPmCWKdWQ+fZNnTpys3AVpfXGnIXHi/5A7aOaOe6bcrmp4hjNUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 216.228.118.232) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=temperror action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WlB7CJkblbu71GHl37/tYt2PEL3oFAKlAjjQ7yk7se8=; b=AAJQBof4XJFmXVOunT4lcN3VFR6/PIU8B5Onhk00+oGCLH8W+8SSqJ1apBy0xp/+lsYo1dXXfT3kUZ7hnVzGVeKuxjGgZ8r/n2vvlFjdGAwGyue/pry2oHPt129xacz9Woz5aJ1iWo9KwCT4mC5RTWTdDrXPRflQP76aDscKKIjnVNwK+3Xe1qKZmzKNWeGXP0YZWEeMpFmCL9bachp2bK8rh6KbanA5gfy7aowB18hsAJ62t9mizbqROfCqb3jXcKDnVsliYc8Cf1vsHLporK4nN3PHV2+dYRG4X2R/yQq1BDlaXncX8eaV3vo2f7CUnU70oMbtm41dinxha7m7tg== Received: from SN1PR12CA0065.namprd12.prod.outlook.com (2603:10b6:802:20::36) by IA0PR12MB7773.namprd12.prod.outlook.com (2603:10b6:208:431::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Thu, 20 Feb 2025 21:41:04 +0000 Received: from SN1PEPF0002636A.namprd02.prod.outlook.com (2603:10b6:802:20:cafe::8c) by SN1PR12CA0065.outlook.office365.com (2603:10b6:802:20::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.15 via Frontend Transport; Thu, 20 Feb 2025 21:41:04 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=nvidia.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of nvidia.com: DNS Timeout) Received: from mail.nvidia.com (216.228.118.232) by SN1PEPF0002636A.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Thu, 20 Feb 2025 21:41:02 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 20 Feb 2025 13:40:46 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 20 Feb 2025 13:40:45 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Thu, 20 Feb 2025 13:40:42 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Gal Pressman , Mark Bloch , "Saeed Mahameed" , Leon Romanovsky , Tariq Toukan , , , , Jianbo Liu , "Leon Romanovsky" , Patrisious Haddad Subject: [PATCH net-next 1/8] net/mlx5e: Add helper function to update IPSec default destination Date: Thu, 20 Feb 2025 23:39:51 +0200 Message-ID: <20250220213959.504304-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250220213959.504304-1-tariqt@nvidia.com> References: <20250220213959.504304-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636A:EE_|IA0PR12MB7773:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bf12087-7687-4ee4-3352-08dd51f745e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?0kPqREEw5J26fMbqkWzf6kifzhbucL4?= =?utf-8?q?Q1EW4cLNcTVPLXzpBPYyAAFkbjQ9EX5y8WE+7zXZCDJKRpWGlerlq+ckIcVci0Y4m?= =?utf-8?q?+5/G+lpEdR3ElSJmLB19bokFiLbYfHfDyh9jFb2dzosB5LGo8QoOQiewFdMCxAfQr?= =?utf-8?q?QBFZ9+GZBjb+Ep6RxmTUeT+5hyZhLcCoIqFfrLIFWTXMGHA4zzGjEDn59XTZUxvob?= =?utf-8?q?IAlzUOnwY3oo6tH6439L3rl+Bhr15qSg6avr8ZwhSpzIKSb73fEE5wb7Nh0+JwRRr?= =?utf-8?q?356Q3S66VXBlEzvrtnzmlFTIsHp/8rcCEo5K3vIvdAzrckmZin4ZTQNMCG1Uu3dtQ?= =?utf-8?q?hvSvNCFqOaO1OPn0SPYslL/tYkPWm/einjDphL/ifJxiX28k1kvyi9DHTwxR3CUhb?= =?utf-8?q?JKLlRO8iuiABiShZZOzOptDRnB/9RAY8tD6ACdEvKjyGGVxMiXZfTPoS3OcViFdWC?= =?utf-8?q?FmubHOdU824dsoYuzk5RM8p96MGSLzcHfr2Iut6pO8KS4S3bSRn2K9Yifd/aINMdH?= =?utf-8?q?MtJGWQ3t4kMqLjC7kGTfl8EgJBPGf4ZW26XFkU7Q7BbybjCnIMvMSnluNMD0M/zIL?= =?utf-8?q?f4wW959805lQQpoju7ZTjnM2GGMLkiq9j0nBngGbFWcYxsvWs7ARx1EBw7ZKTY9PX?= =?utf-8?q?X9y3fQjLuN4+XZC/VhaWW97P+Yb6VXm7a2IL3Tf75/mHTSfcs+8xBHaYYDs42NCik?= =?utf-8?q?F+5LJF2f2H8e7Esn22LmYConHBc1mWiX2ZcRa7aISWxwsSojqKIBxBkYlkJrS6abm?= =?utf-8?q?sSO8OQFTGgJdwtHDGQO83glWVhY23hoVZLgE/DrjsTlie1dpq4zBS7B/Veva9Bdqg?= =?utf-8?q?9a1qZKKkzoIw/zS0AEotLB5yjuzH+9UdDpkNg7c3Jfw5cnvMCRo6ilBDr1ZHvPaC5?= =?utf-8?q?DURCH88761s7zHvlaHVZ89N0Xn4hd8C1SuVW3sVFd/LSiyEicKxuGhJggGXIXBjgU?= =?utf-8?q?l/GFUWn0ofgjhBIKDkw6xUMQvzoHakGcCSvD5QUnaSdoN+7lRBnOKbhCL2ZmLyCmq?= =?utf-8?q?+IEvEcSPhF1ao57u3CYUZURGahPps5bGxlzUcp7v6HiYqc+u5nUBWqdUiDZqYVPBw?= =?utf-8?q?aUSlf04a6ciuOCwjqib416UurCFYFKDj436gv19FtMUnZOFDbhjmUGbkBEMpAm0m/?= =?utf-8?q?tR5vF6Kedksbwvzz0Bxshn6Kbkut26SQ9bgNT1ek2hISRc1aEKe4W7l5g+zBTUfZ5?= =?utf-8?q?Lbtj4rok4jhXOv2y0GgYOPldY/+jeW4gjwb6MwgocNWzhcZDED4It1xwdvxTKtkw2?= =?utf-8?q?72Wt2EqO/0DhDJtwz+OpaPoMsGD2peRGs4HQNUvvkBDxuG0yt9jrXw7uKpcwy+pzn?= =?utf-8?q?Z/nl7HsvAvjR/MTcQ/VrKFMGqnecO3yTrTcRmSg3wtkoDNtd87r9okdeGRCNZEtoL?= =?utf-8?q?Pj9D2EX8Ho06Q+Bc1vEWxgiu6ngEi63WUujOQHeduWlcHA51JtHI4I=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 21:41:02.6361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf12087-7687-4ee4-3352-08dd51f745e3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7773 X-Patchwork-Delegate: kuba@kernel.org From: Jianbo Liu The default destination of IPSec steering rules for MPV mode will be updated when the master device is brought up or down. Move the common code into the helper function. It’s convenient to update destinations in later patches. Signed-off-by: Jianbo Liu Reviewed-by: Leon Romanovsky Reviewed-by: Patrisious Haddad Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/en_accel/ipsec_fs.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c index e7b64679f121..7f82d530d3e1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -493,6 +493,14 @@ static int ipsec_miss_create(struct mlx5_core_dev *mdev, return err; } +static void ipsec_rx_update_default_dest(struct mlx5e_ipsec_rx *rx, + struct mlx5_flow_destination *old_dest, + struct mlx5_flow_destination *new_dest) +{ + mlx5_modify_rule_destination(rx->status.rule, new_dest, old_dest); + mlx5_modify_rule_destination(rx->sa.rule, new_dest, old_dest); +} + static void handle_ipsec_rx_bringup(struct mlx5e_ipsec *ipsec, u32 family) { struct mlx5e_ipsec_rx *rx = ipsec_rx(ipsec, family, XFRM_DEV_OFFLOAD_PACKET); @@ -507,8 +515,7 @@ static void handle_ipsec_rx_bringup(struct mlx5e_ipsec *ipsec, u32 family) new_dest.ft = mlx5_ipsec_fs_roce_ft_get(ipsec->roce, family); new_dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE; - mlx5_modify_rule_destination(rx->status.rule, &new_dest, &old_dest); - mlx5_modify_rule_destination(rx->sa.rule, &new_dest, &old_dest); + ipsec_rx_update_default_dest(rx, &old_dest, &new_dest); } static void handle_ipsec_rx_cleanup(struct mlx5e_ipsec *ipsec, u32 family) @@ -520,8 +527,7 @@ static void handle_ipsec_rx_cleanup(struct mlx5e_ipsec *ipsec, u32 family) old_dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE; new_dest = mlx5_ttc_get_default_dest(mlx5e_fs_get_ttc(ipsec->fs, false), family2tt(family)); - mlx5_modify_rule_destination(rx->sa.rule, &new_dest, &old_dest); - mlx5_modify_rule_destination(rx->status.rule, &new_dest, &old_dest); + ipsec_rx_update_default_dest(rx, &old_dest, &new_dest); mlx5_ipsec_fs_roce_rx_destroy(ipsec->roce, family, ipsec->mdev); }