From patchwork Tue Mar 4 07:21:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Fang X-Patchwork-Id: 14000089 X-Patchwork-Delegate: kuba@kernel.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2052.outbound.protection.outlook.com [40.107.247.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077FE1FC7EC; Tue, 4 Mar 2025 07:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073995; cv=fail; b=pUpjouuzjh/8qA0TxRsnDa+F4DzJCHaQvN95Diode/vn1i9TFoNam6drc1trKNesOZ+Dhx7Dh289sFvIO9L1PSqpfW+YlVLh9KWIDHcjL0LOnnJDH9vpQwl52IjirzCMH6yKPsVda8DobuRb0AYQ24HfzE4PqVwsNL+plZuqoDY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073995; c=relaxed/simple; bh=KCAVFanUb49qIcNrxgFEkMfFUL/he9SEKrjuSyMK7KI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=J76m3G3N/z7zMcZ1pv8HHBPGS5Cg0lEs7zu3IlazpzDNsm/g/y0L9mEpSNkWRUa2ZhEbDF1+djCpF92ZyZe/IrAIzlTlUfo4gPH5NPSr0B/GCB/2QzqxfpuFl5dwplXdvUldbcI6ivGYiaDCjDCvKd50D4LTi4WX+pqxt5TOqLs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BonNWS0F; arc=fail smtp.client-ip=40.107.247.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BonNWS0F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NV1Qd9/RtgyLSR7BqxGaQEyxVnL6EYMSWSWAVMyh7S4QbhAQInsDuhRz4dyROs3BQIXyjYos7C7y9zArET+uqq2fQiA9oG/WkUIBd9cy4LSMOjDA6Ni6sSy3dEnTQMLOCtva89cnyf47C18ujEiRbppsNDIB6Uu5a7trByd+P8u3f8pZmi99y6IBiWP0+PshyIjRaQWu9f9tdGtAte7y/me769hAsOydtehrSIGNV5TEPhb8d73iTOYCcg5koJYkdiLmBNP2YQIyetLgHGLd63DTECutApz63KW1uVadhMJH8ZYKzVHc6ic2qiGEarnD55T1JfmK3/EfJgxlwsEqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HoxKe9nMDtDGc8hjS8LOCJjBUHVr26Bvwn0zgatxHP0=; b=oLz2Z4kSinyg+Avcq9Hk0YoRh2JTpNB3b0Hcz0GPXTv5A26IJOT2Y+oJYtTc2vkoPl+tqk0V681tloIVoT280rtkqaG87LAsAhbnKppp763aTO081VC46wC/Gb5sWIpDBNaZNGFTQuABFijoQGdeMVknPAN3zdymW2smBml6dYlWpgCDuspYTU9Udxriia1pjUi9rMvDpXKrVNzScuzm7zqgsrq/45NDZ9TZgEqsaMYtr2uwKkYqKXVVrCE461L643ycK6lU2862V3o+r+fUh6dBFcJ9BSrvkq8sR9GQxKSUix4HOyvALQ0I7S8qQloqxljYgo5GGjqWj68kr8dQrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HoxKe9nMDtDGc8hjS8LOCJjBUHVr26Bvwn0zgatxHP0=; b=BonNWS0FJcjF0TnFRPXpbn/gP0E2lW+YznB4ybMgJEJ3npuuGZvR8C2x5p9/u3fZYzM1OoG+73iaoUZLdhpp9Eh7EN7jpX7ppSmM1u+piFLG5zrfNeo/qi/qcy+KtP2D6Aj0HNXHyR76TZn6XxqLZNl1qsnA3RGLaBJomyZMUahhqhxs0jZ6Gb5sFDyue8xMuMaKu9TF0AObM6pNvj2Lf/6HTT1WILDdcCdCjzQAlDz8WNFfpvmUgTsU/T1Dc/ZwCKgXZriOkP0lyw78z/OC3+I6ax7SPKIMn/EB2f5XAmI0YtorcUKEWmfFpQViMs1tfljEPjApAEcE0njakkDXtw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by VI2PR04MB11171.eurprd04.prod.outlook.com (2603:10a6:800:29a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Tue, 4 Mar 2025 07:39:50 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%5]) with mapi id 15.20.8466.020; Tue, 4 Mar 2025 07:39:49 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: christophe.leroy@csgroup.eu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 net-next 07/13] net: enetc: check if the RSS hfunc is toeplitz Date: Tue, 4 Mar 2025 15:21:55 +0800 Message-Id: <20250304072201.1332603-8-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250304072201.1332603-1-wei.fang@nxp.com> References: <20250304072201.1332603-1-wei.fang@nxp.com> X-ClientProxiedBy: SG3P274CA0007.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::19) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|VI2PR04MB11171:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fdfa83e-d852-4981-c695-08dd5aefbe64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|366016|1800799024|376014|38350700014; X-Microsoft-Antispam-Message-Info: ZQ91RvvU94tuifTlV0vc3U4rYYih25Bs3K0XneaxJNqQhkD4e0/6aJeXUEE4Ffp2goxslPUwB2wYhYwuhe3gY7FaTUBBxgj2n6UQHlXg4Uu/23nTpmob+rFIpkgXeYNn6JhAEsUzmEydBN6OLi9ig8n2hyrguEbgWqc/TJp3YVrEOSnneLg8YNJDB8FZK0peVKOKRQKU4DRirqSftykvnmBgZ51lHVok3/CDDUH7GMxgzKzsTcn6KNr8GD+GC4pijuPug3NMVb2rsbfup6eOPPHfmfV1sZ1EU/RNkl5UlVG7Ph15FnVIC3iU/BfiH/nEaiAeO2hlbCYmYeSu9Dlk27SOtHgArI+6WMGOapOwthEEswS0RWjsLWB81ApoGnjpMZaRU3QeIot4oVedtLMvvXp5wiWxcQNSzBdjqLFFWogPx/UFOUV0wMYB+sgAGM54dCr9pTNKB4xB5yx44jtOAlF2TZiGe1G9vtlI6VXquRd3eMh+0VWmDv7gwOa5fL4uh3wyrF1UT2MBL4qhXN0LSsNGVSTo4rjbPUd3AYdZcp/L1LNtlmfCnPFU/ahQoi2qAyUNN6VH27NthUVGijWQ1MISMwA/3QbCAfFMkOHkTzDolbhHMwzGkeGklrbBkMmW4vaRZEK+vqyeFF+TroXdf+h5FTFAjIjb45G91Zz93DJJDiqq8NbX6IdWt90FA/KOcSiLKmrd36YVmJwVV1ZA4veTxCdnGiMSTIcAOOF6V0BtIBIrnQHEe0QUejlIJP+oETT/38qtCtsL/AZ0n4w+pm0obZUz37tNq+cGfK+fxw/Q4qVPpL5X8wx3acGYXKWXtx7k9UJGO1FDn2vJBYNN+wook3rFx4tBoL5iUMoBoB/bEZWjd5mhFFeSC7wT8O0vIFFBmB91zs+/H80d1BJSJdRH4RLI534/jBiLQrtUXJ1yWTxItzE2hRIKlztOGCtq7itCKKl0pYxGjXpSNzsrzshYdDW5O+/2xT8rjZCD50aDyMjS9RufDwg9x34+r/FGFhEucJH0XXe78Bf/6bhHtVo3m9l10V2MokD1Ilmwcd0nHc0gIexN3NU9453mZZO42GDyM+OXes0oXufNh8xIlwCAYCbUIVbnRX2WFeY2h0lIBw/YAJ5xtRSzoHLvqte4PCRyoBujckmr3FzRa2JaB226hSqSF/Mtr7BEC5byoaCTs9kXlghH0/J9+d1fwleL4T+rre9bcmbSsV1Wi7TZGO43WxucqZnCeizsJdr9bc4drZTp9Mn1Xf4nwmSKppdYRd+9UEDrSJJAP2H64279VRIZ2Wvsdf+okYn+J5bmK5rSFF1/UVpFzGmbJshADwQgYDieuXH0oWt+IJIUR/eity+Yz7PlXxfq6M74CwmypRJKLmczczKeThKuoBQywJI5iqRZj+9FimTDgEGRNDrRY27dfOYgA01w4vRaw216q4eXDbhPnji6WY3dxdZNKRWR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(366016)(1800799024)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oSGg8auUIPzy6JzquCtu0JDunZuWu3be50R1tanyFxnfrTIe7WADaQHSqifWWQqhMM+8zj84Eg1DJcCC6CDVeSnfqqZP5gBxfEw1bumhyVs41sNOoU8ichROZ+Z9W3yC9h+ImO2CXJ78T2luxzd2wFLVD3tKNhWmBo+EPqo8oaYnyGK3R6Tp9wj2G5deERPExEIT7FbaSDSpQSPT+irpRK1DUVTRj1S7DN8rv3/rWrpZA/Ch00YcgReCUBNGZzbjRUNn4+0ogUj91LuoxYQucTt3ZE2HPrGi2iEOxZnE4xMscf2GZ0V1IfxznSbIcbjlh4pTXNFJT3WAOt4es4/nTnks8AWIJmPK6+L5RVXEiARlRWQ0QdOgIQ59tlUCQwwae7NZe6JLiAcOCW3ekr0Sgun1nswzaH1R797XWIl735nvk6gl/xzMb5myCP9UEU++BUldpQldhwRc+XwD74rERu7NiilxHvm+mx7E4ZZQlyF+hzuUYP9Ic75gUg/dIIsza0LCV654X/v8KwrHUt6w4RNbcSNP8R61Tu4r9RQe+eszwm5V+yaNyll3WwowT9m5jbTxWv9dgpKO//5EfyMcUMgmP+LS/TkCqKxZUqAamrdhohVq+I1OSewm7jAJ0Poe1iAr1M+YsMuvNyB6TMYyWdAPHyYE/EbCq+z5dFWe6yYXthyyHszwvOnsoGq/DhYvFDQIcGTE+f4R/xmWgIKhqQlW7Nk37QXKHJ8sJ8sW0/4hTHcnx7zpEOgaChx9Hq1jXIwErUEjxJsTQDuuraMqaG4BLVbLvqNMT3gkZ1+wjOIDoUjwrPR+0/MMan9Lz/msbvgjJe07HttVCAaZfXJ+RGNrcwS4yIqKDTV84qlpMLiOC664c8e0oU893wJ4MY+694QyYvGjFgjlvLRbgMjW5z6xWw2Xmtxt7pLnRm2s4msnyJ0mhkUuQBfT/rc54RiXQNuEBtmxwieyDxtiOrqfSZGisTqrF++me/cwioFf0DSYFCSmoE4/EHZzBToK680Bq7fp9Ot+sb+Hca92l02JgJB6PEz8WH1+EqPP1edX1OwTqNijHixY2i34yooNsmb+kAoH/WF9fUJadkUANacaUClJ6NgNJvgJyp1LA1waNmU+5cFPvleC49+f55GhQSOJhae02u15G9Cc4PtBx08Ag+UP72LHO4A0eCUk5C4ca9WrU4QIoE18eKXzmyKVBBIQGNJDdVN3H4U94Lx98bKGTawE0b3mpfvrt4mhAcicc79gZn4+cbNCLseqdxgtWzWBBiyzb9IJo0CT4D5uq4S87byaQEvixhp586K5RePG8JtHsEk0kRYwuRF2Pd18v6skU527pjATaPtC+ASzDVB8QJmm1CH3nIQTU12jzQDzsUOjcVZ67uo6Z3RLWWyp8AjiLtBZ/yyHyRaR0OiRADD8C+SeIRGXFUlww1hCkI+P1v7o5ATre++8SpwyzfWLFLKUOwMgPxFZ6dTl4CJNyQIYUGmeOPwOBecKwRBwJRLKTqYx8HPqiSX8+whsUg5ZUduJfNQqPEwo7j6gNsa4uhDwWzmnnrgclGdLJPo+60mHZjnaR02P+jGVhrwhpbrB3uKL X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fdfa83e-d852-4981-c695-08dd5aefbe64 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2025 07:39:49.7972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jpV608gzoEIedHQv/S+SmXjqK9FUsUk80yMqMeLfj1Wy13MdYeZriTESCgZ7R8IL4lHyTwLxAERdHIDpZeR+3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB11171 X-Patchwork-Delegate: kuba@kernel.org Both ENETC v1 and ENETC v4 only support the toeplitz algorithm for RSS, so add a check for RSS hfunc. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c index bc65135925b8..6a47e2bd1d4f 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -753,6 +753,13 @@ static int enetc_set_rxfh(struct net_device *ndev, struct enetc_si *si = priv->si; int err = 0; + if (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE && + rxfh->hfunc != ETH_RSS_HASH_TOP) { + netdev_err(ndev, "Only toeplitz hash function is supported\n"); + + return -EOPNOTSUPP; + } + /* set hash key, if PF */ if (rxfh->key && enetc_si_is_pf(si)) enetc_set_rss_key(si, rxfh->key);