| Message ID | 20250306145150.1757263-3-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bfb522f347df2d1fefc43f7b42e361321bc010d9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | eth: fbnic: support ring size configuration | expand |
On Thu, Mar 06, 2025 at 06:51:49AM -0800, Jakub Kicinski wrote: > We should be validating the Rx count on the Rx struct, > not the Tx struct. There is no real change here, rx_stats > and tx_stats are instances of the same struct. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Good catch. Acked-by: Joe Damato <jdamato@fastly.com>
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c index 2d2d41c6891b..ac11389a764c 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c @@ -1221,7 +1221,7 @@ void fbnic_aggregate_ring_rx_counters(struct fbnic_net *fbn, fbn->rx_stats.rx.csum_complete += stats->rx.csum_complete; fbn->rx_stats.rx.csum_none += stats->rx.csum_none; /* Remember to add new stats here */ - BUILD_BUG_ON(sizeof(fbn->tx_stats.rx) / 8 != 3); + BUILD_BUG_ON(sizeof(fbn->rx_stats.rx) / 8 != 3); } void fbnic_aggregate_ring_tx_counters(struct fbnic_net *fbn,
We should be validating the Rx count on the Rx struct, not the Tx struct. There is no real change here, rx_stats and tx_stats are instances of the same struct. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)