| Message ID | 20250307-mlx5-comma-v1-1-934deb6927bb@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 17fef2042338e19ed7b57484da4db9e3a3b47c76 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/mlx5: Avoid unnecessary use of comma operator | expand |
On Fri, Mar 07, 2025 at 12:39:33PM +0000, Simon Horman wrote: > Although it does not seem to have any untoward side-effects, > the use of ';' to separate to assignments seems more appropriate than ','. > > Flagged by clang-19 -Wcomma > > No functional change intended. > Compile tested only. > > Signed-off-by: Simon Horman <horms@kernel.org> > --- > drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > index c862dd28c466..e8cc91a9bd82 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > @@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains) > goto err_ignore; > } > > - chain = mlx5_chains_get_chain_range(chains), > + chain = mlx5_chains_get_chain_range(chains); > prio = mlx5_chains_get_prio_range(chains); > level = mlx5_chains_get_level_range(chains); Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
On 07/03/2025 14:39, Simon Horman wrote: > Although it does not seem to have any untoward side-effects, > the use of ';' to separate to assignments seems more appropriate than ','. > > Flagged by clang-19 -Wcomma > > No functional change intended. > Compile tested only. > > Signed-off-by: Simon Horman <horms@kernel.org> > --- > drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > index c862dd28c466..e8cc91a9bd82 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c > @@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains) > goto err_ignore; > } > > - chain = mlx5_chains_get_chain_range(chains), > + chain = mlx5_chains_get_chain_range(chains); > prio = mlx5_chains_get_prio_range(chains); > level = mlx5_chains_get_level_range(chains); > > > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Thanks.
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 07 Mar 2025 12:39:33 +0000 you wrote: > Although it does not seem to have any untoward side-effects, > the use of ';' to separate to assignments seems more appropriate than ','. > > Flagged by clang-19 -Wcomma > > No functional change intended. > Compile tested only. > > [...] Here is the summary with links: - [net-next] net/mlx5: Avoid unnecessary use of comma operator https://git.kernel.org/netdev/net-next/c/17fef2042338 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c index c862dd28c466..e8cc91a9bd82 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c @@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains) goto err_ignore; } - chain = mlx5_chains_get_chain_range(chains), + chain = mlx5_chains_get_chain_range(chains); prio = mlx5_chains_get_prio_range(chains); level = mlx5_chains_get_level_range(chains);
Although it does not seem to have any untoward side-effects, the use of ';' to separate to assignments seems more appropriate than ','. Flagged by clang-19 -Wcomma No functional change intended. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)